Use Thread.each_caller_location over caller_locations#144
Open
joshuay03 wants to merge 1 commit intobasecamp:masterfrom
Open
Use Thread.each_caller_location over caller_locations#144joshuay03 wants to merge 1 commit intobasecamp:masterfrom
Thread.each_caller_location over caller_locations#144joshuay03 wants to merge 1 commit intobasecamp:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm doing some profiling of our app which uses v1.11.1 of this gem and the
callerhere shows up as both a time and allocation hotspot.I was about to send a PR but noticed it has already been improved in #138 by switching to
caller_locations. Here, I'd like to follow-up on that by addressing this comment to instead useThread.each_caller_location, having done some benchmarking to confirm that it indeed provides better results in this case.Benchmarks
Could I also please request a new release if this is merged? 🙏🏽