feat: add config option to enable path-style URLs for S3 API calls#233
feat: add config option to enable path-style URLs for S3 API calls#233tcsavage wants to merge 1 commit intoaws-controllers-k8s:mainfrom
Conversation
… services Adds a UsePathStyle config field and --aws-endpoint-use-path-style CLI flag to force path-style S3 URLs (e.g. http://host/bucket/key), required when using S3-compatible services such as LocalStack.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tcsavage The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @tcsavage. Thanks for your PR. I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Issue #, if available: aws-controllers-k8s/community#2237
Description of changes:
In order to support some S3-compatible APIs (e.g. LocalStack on a local dev cluster) it may be necessary to force the S3 client to use "path-style" URLs (e.g. http://host/bucket/key).
This PR adds a
UsePathStyleconfig field and--aws-endpoint-use-path-styleCLI flag to force path-style S3 URLs. This will be used by the S3 controller to configure the service client.Associated PRs:
code-generatorPR.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.