Skip to content

feat: add new_resource_manager_client_options hook to manager template#684

Open
tcsavage wants to merge 1 commit intoaws-controllers-k8s:mainfrom
tcsavage:feat/s3-path-style-url
Open

feat: add new_resource_manager_client_options hook to manager template#684
tcsavage wants to merge 1 commit intoaws-controllers-k8s:mainfrom
tcsavage:feat/s3-path-style-url

Conversation

@tcsavage
Copy link
Copy Markdown

@tcsavage tcsavage commented Apr 2, 2026

Issue #, if available: aws-controllers-k8s/community#2237

Description of changes:

In order to support some S3-compatible APIs (e.g. LocalStack on a local dev cluster) it may be necessary to force the S3 client to use "path-style" URLs (e.g. http://host/bucket/key).

This PR adds a hook injection point in newResourceManager to allow service controllers to pass custom options to the AWS SDK client constructor.

This will let the S3 controller set UsePathStyle based on the value set in its controller config.

Associated PRs:

  • s3-controller#214 uses this hook to control UsePathStyle.
  • runtime#233 adds a new config option used by the s3-controller to set UsePathStyle.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Adds a hook injection point in newResourceManager to allow service
controllers to pass custom options to the AWS SDK client constructor.
@ack-prow ack-prow bot requested review from jlbutler and knottnt April 2, 2026 07:38
@ack-prow
Copy link
Copy Markdown

ack-prow bot commented Apr 2, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tcsavage
Once this PR has been reviewed and has the lgtm label, please assign jlbutler for approval by writing /assign @jlbutler in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 2, 2026
@ack-prow
Copy link
Copy Markdown

ack-prow bot commented Apr 2, 2026

Hi @tcsavage. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant