feat(UI-1541): improve project creation from yml#401
Merged
Conversation
RonenMars
reviewed
May 25, 2025
| }); | ||
|
|
||
| if (createError) { | ||
| commands.executeCommand(vsCommands.showErrorMessage, namespaces.applyManifest, (createError as Error).message); |
Collaborator
There was a problem hiding this comment.
Please write an appropriate error message using translate.
Also, please write to Logger.
Collaborator
There was a problem hiding this comment.
You can even do something like this:
const errorMessage = (createError as Error).message;
const isProjectAlreadyExists = errorMessage.includes('SERVER MESSAGE - PROJECT EXIST');
if (isProjectAlreadyExists) {
// display proper message and log - so the user will easily understand what is the problem
return;
}
Collaborator
Author
There was a problem hiding this comment.
But we have already had Logger inside ProjectsService, and If have error it will show message or I something don't understand
10 tasks
Collaborator
Author
|
Reviewed |
4ead8c5 to
94c87f6
Compare
…root, but only staged
89c3b71 to
0e8a127
Compare
RonenMars
approved these changes
Oct 15, 2025
haimzlato
approved these changes
Oct 15, 2025
|
🎉 This issue has been resolved in version 0.20.22 🎉 The release is available on GitHub release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
For check limit request to server, instead of creating project by applyManifest,using projectClient.create
Linear Ticket
https://linear.app/autokitteh/issue/UI-1541/webui-templates-vscode-extension
What type of PR is this? (check all applicable)
Code Standards
elseby employing early returns to make code more readable and less nested.!importantin CSS where possible.