feat(UI-1541): improve project creation from template#1199
Merged
Conversation
J1za
changed the title
RonenMars
reviewed
May 27, 2025
J1za
commented
May 28, 2025
RonenMars
approved these changes
Jun 1, 2025
RonenMars
reviewed
Jun 1, 2025
J1za
force-pushed
the
vitaly/feat/improve-create-project-from-template
branch
from
3818b25 to
88e4756
Compare
RonenMars
approved these changes
Jun 3, 2025
RonenMars
reviewed
Jun 3, 2025
src/store/useProjectStore.ts
Outdated
| } | ||
|
|
||
| projectName = project.name; | ||
| return { data: undefined, error: new Error(t("projectNameRequiredManifest", { ns: "errors" })) }; |
Contributor
There was a problem hiding this comment.
Nit: Could you please move this translation from the "errors" namespace to either "stores.projects", "stores.templates", or another namespace you find more appropriate?
Contributor
Author
There was a problem hiding this comment.
Moved to stores.projects, that's a good idea
RonenMars
force-pushed
the
vitaly/feat/improve-create-project-from-template
branch
from
4ad62ca to
c530b4c
Compare
J1za
commented
Jun 10, 2025
| <ContinueTourModal onCancel={cancelTour} onContinue={continueTour} /> | ||
| <RateLimitModal isRetrying={isRetrying} onRetryClick={onRetryClick} /> | ||
| <QuotaLimitModal onContactSupportClick={onContactSupportClick} /> | ||
| <RateLimitModal isRetrying={isRetrying} onClose={hideRateLimitModal} onRetryClick={onRetryClick} /> |
Contributor
Author
There was a problem hiding this comment.
I don't understand why you add prop onClose, if we close the modal from ModalStore
J1za
commented
Jun 10, 2025
| }: CustomEvent<{ limit: string; resourceName: string; used: string }>) => { | ||
| if (!quotaLimitModalDisplayed) { | ||
| closeAllModals(); | ||
| setTimeout(() => { |
Contributor
Author
There was a problem hiding this comment.
setTimeout revert to guarantee opening modal
Contributor
Author
|
Reviewed |
Contributor
|
Reviewed changes & approved |
RonenMars
force-pushed
the
vitaly/feat/improve-create-project-from-template
branch
from
df13be1 to
1e3554f
Compare
|
🎉 This PR is included in version 2.200.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
RonenMars
added a commit
that referenced
this pull request
Jul 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For check limit request to server, instead of creating project by applyManifest,using projectClient.create
Linear Ticket
https://linear.app/autokitteh/issue/UI-1541/webui-templates-vscode-extension
What type of PR is this? (check all applicable)