Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
scripts/autogenerate_files.sh
Outdated
| copy_docs() { | ||
| src="$1" | ||
| dest="$2" | ||
| [[ -d "$dest" ]] && dest="$dest/$(basename "$src")" |
There was a problem hiding this comment.
The new copy_docs uses [[ -d "$dest" ]] under a /usr/bin/env sh shebang. On systems where sh is dash (Debian/Ubuntu default), [[ is unsupported and the script now aborts with a syntax error before copying any docs. Use POSIX [ -d "$dest" ] or switch the shebang to bash to keep the tool runnable.
Useful? React with 👍 / 👎.
|
I guess if we did want to do this, we'd need to remove the CI check that specifically tests we didn't change anything... |
|
Adding @zanieb as a reviewer. Low priority, no rush, etc. I'm curious to get your take as the CEO-at-large of Rooster :) |
| } | ||
| copy_docs ./ruff/crates/ty/docs/cli.md ./docs/reference/ | ||
| copy_docs ./ruff/crates/ty/docs/configuration.md ./docs/reference/ | ||
| copy_docs ./ruff/crates/ty/docs/rules.md ./docs/reference/ |
There was a problem hiding this comment.
I think we only need this for rules.md, no other markdown file contains line-references
|
Hmm, you now run into issues with our check-generated files unedited. That script will require the same pre-processing |
2 participants
This is a drive-by fix/idea. I noticed that we're publishing links with line numbers that tend to go stale as the upstream Rust code is edited over time (like most of the "View source" links on this page). Might be nice to snapshot these when we vendor the
.mdfiles?