Conversation
CHANGELOG.md
Outdated
| - Add cycle detection to ty's implementation of disjointness between types, fixing a possible source of stack overflows when analysing recursive types ([#19139](https://github.com/astral-sh/ruff/pull/19139)) | ||
| - Don't allow first-party code to shadow the stdlib `types` module ([#19128](https://github.com/astral-sh/ruff/pull/19128)). | ||
| This fixes another possible source of stack overflows. | ||
| This fixes another possible source of stack overflows. |
There was a problem hiding this comment.
Have past releasers been editing out the autoformatting corrections by hand maybe?
There was a problem hiding this comment.
I don't recall anything like this coming up before. Are you sure this wasn't done by your editor, rather than any in-repo-configured tooling?
There was a problem hiding this comment.
Hmm, if I run release.sh on a clean branch off origin/main, I still see these edits. If it doesn't repro that easily for you, I wonder if I have a different local version of something.
There was a problem hiding this comment.
Specifically, if I update the ruff submodule and then git add that, then I can run uv run --isolated --only-group release rooster release and see these edits (in addition to the new changelog entry at the top).
There was a problem hiding this comment.
I'm not sure (and I haven't tried to repro locally). cc @zanieb re Rooster. I need to run to lunch now but can look later. I guess maybe we can manually edit these out for now to keep the release moving?
There was a problem hiding this comment.
Ah ok, CI is failing when it runs the pre-commit hooks. It looks like I just hadn't set those up. When I do a pre-commit install and redo this, the diff goes away (actually it fails the first attempt to commit). I'll manually edit them out of this PR.
There was a problem hiding this comment.
I've also tweaked the release instructions to call this out: 47b6ad0
These happened because I didn't have the pre-commit hooks installed.
Co-authored-by: Carl Meyer <carl@astral.sh>
Co-authored-by: Carl Meyer <carl@astral.sh>
Co-authored-by: Carl Meyer <carl@astral.sh>
Co-authored-by: Carl Meyer <carl@astral.sh>
Co-authored-by: Carl Meyer <carl@astral.sh>
Co-authored-by: Carl Meyer <carl@astral.sh>
Co-authored-by: Carl Meyer <carl@astral.sh>
Co-authored-by: Carl Meyer <carl@astral.sh>
This fixes a feature that's shipping in this release, so it won't get a separate mention in the CHANGELOG.
|
(I'd rather leave #1636 for review by someone with more context on our docs build, so let's ship this one without it. Thanks for observing that opportunity for improvement, hopefully we can get it in for the beta.) |
|
|
|
|
3 participants
I've kept the edits to the CHANGELOG in a separate commit here so that we can eyeball them.
On a lark I've also put up #1636 to see if we might want to pin commit hashes in "View source" links, but I haven't used that here. If we wanted to, I could rebase it.