-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Raspberry Pi: Add uncompressed wireless FW to Ubuntu releases #9330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Ubuntu uses compressed "*.zst" firmware of which the kernel has issue. Signed-off-by: Patrick Yavitz <pyavitz@gmail.com>
📝 WalkthroughWalkthroughRemoved Changes
Sequence Diagram(s)sequenceDiagram
participant Build as Build System
participant Git as Remote Git Repo
participant FS as BSP Image FS
rect rgba(200,220,255,0.5)
Build->>Git: clone brcm firmware repo
Git-->>Build: repo contents
Build->>FS: copy firmware into lib/firmware (pre-install)
FS-->>Build: write/verify files
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@config/sources/families/bcm2711.conf`:
- Around line 257-263: The function
pre_install_distribution_specific__ubuntu_raspi_firmware currently runs
chroot_sdcard git clone inside the target rootfs; instead, on the host use the
existing fetch_from_repo helper to fetch the firmware at a pinned commit and
then copy it into the target (into "${SDCARD}/lib/firmware/updates"), removing
any .git metadata; replace the chroot_sdcard git clone call with fetch_from_repo
(specifying repository URL, branch/commit/tag), then use host-level copy to
populate lib/firmware/updates and rm -fdr the .git directory to avoid adding git
as a chroot dependency and ensure reproducible builds.
Signed-off-by: Patrick Yavitz <pyavitz@gmail.com>
|
✅ This PR has been reviewed and approved — all set for merge! |
|
I don't think this is required anymore. At least not on 6.18.y and up. Could just close this PR and open another removing the |
Ubuntu uses compressed "*.zst" firmware of which the kernel has issue.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.