Skip to content

Conversation

@pyavitz
Copy link
Collaborator

@pyavitz pyavitz commented Feb 2, 2026

No longer required using linux-6.18.y and up. #9330 (comment)

Summary by CodeRabbit

  • Changes
    • Modified Raspberry Pi firmware handling during system installation

✏️ Tip: You can customize this high-level summary in your review settings.

No longer required using linux-6.18.y and up.

Signed-off-by: Patrick Yavitz <pyavitz@gmail.com>
@pyavitz pyavitz requested a review from igorpecovnik as a code owner February 2, 2026 00:56
@github-actions github-actions bot added 02 Milestone: First quarter release size/small PR with less then 50 lines labels Feb 2, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 2, 2026

📝 Walkthrough

Walkthrough

Two duplicate definitions of the post_family_tweaks_bsp__rpi_firmware() function were removed from the BCM2711 family configuration file. No replacement logic or alternative implementations are introduced, reducing the post-tweaks behavior for Raspberry Pi firmware handling.

Changes

Cohort / File(s) Summary
Firmware Configuration Cleanup
config/sources/families/bcm2711.conf
Removed two duplicate function definitions for Raspberry Pi firmware post-tweaks handling; no replacement logic introduced.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 Two functions hopped away so neat,
Duplicates deleted, the code looks sweet!
Firmware tweaks simplified with care,
Cleaner config floating through the air! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately and concisely describes the main change: removing a specific function from the bcm2711 configuration file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... labels Feb 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

02 Milestone: First quarter release Hardware Hardware related like kernel, U-Boot, ... Needs review Seeking for review size/small PR with less then 50 lines

Development

Successfully merging this pull request may close these issues.

1 participant