Open
Conversation
mergeable
bot
added
c++
python
github_actions
CJCombrink
commented
Mar 4, 2026
CJCombrink
commented
Mar 4, 2026
lib/py/src/Thrift.py
Outdated
| LIST = 15 | ||
| UTF8 = 16 | ||
| UTF16 = 17 | ||
| UTF8 = 11 |
Contributor
Author
There was a problem hiding this comment.
Relates to my other comment, same applies here
5 tasks
- Correctly fail with error code when there are errors so that cmake/make fails - Set up dependencies so that changes are built for any affected file
- Tested against itself and C++ to start with - Cleaned out known_failures (some had unsupported protocols even)
- RAII wrappers to prevent leaks - Optimisze with INTERN_STRING
- Clean out known failures between go and py - Appears there is some ssl issue for some of the tests
- It is not in the spec and string can be used
- Probably found a buf in the JSON protocol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add UUID support for Python
[skip ci]anywhere in the commit message to free up build resources.