Skip to content

THRIFT-5924: UUID support for NodeTS#3331

Open
CJCombrink wants to merge 9 commits intoapache:masterfrom
CJCombrink:uuid_nodejs
Open

THRIFT-5924: UUID support for NodeTS#3331
CJCombrink wants to merge 9 commits intoapache:masterfrom
CJCombrink:uuid_nodejs

Conversation

@CJCombrink
Copy link
Contributor

Attempt to add UUID support for NodeTS and NodeJS

Disclaimer: I don't develop in any one of these languages thus not sure if what I have done is correct

I still want to add nodejs and nodets in the cross tests but opening this so long in the hope for directed feedback about what is done. I also need to figure out what is needed to run these tests stand alone if anyone can assist it will be appreciated

  • Did you create an Apache Jira ticket? THRIFT-5924: UUID support for nodejs and nodets
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was copied from the "test/keys" folder, I will try to use them from there instead and remove them here if I succeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant