Skip to content

[CORE] Optimize the verboseString of ColumnarShuffleExchangeExec #10846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhztheplayer merged 1 commit into from
Oct 8, 2025
Merged

[CORE] Optimize the verboseString of ColumnarShuffleExchangeExec #10846

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions ...substrait/src/main/scala/org/apache/spark/sql/execution/ColumnarShuffleExchangeExec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ import org.apache.spark.sql.catalyst.InternalRow
import org.apache.spark.sql.catalyst.expressions.Attribute
import org.apache.spark.sql.catalyst.plans.logical.Statistics
import org.apache.spark.sql.catalyst.plans.physical._
import org.apache.spark.sql.catalyst.util.truncatedString
import org.apache.spark.sql.execution.CoalesceExec.EmptyPartition
import org.apache.spark.sql.execution.exchange._
import org.apache.spark.sql.execution.metric.SQLShuffleWriteMetricsReporter
Expand Down Expand Up @@ -148,12 +149,16 @@ case class ColumnarShuffleExchangeExec(
cachedShuffleRDD
}

override def verboseString(maxFields: Int): String = toString(super.verboseString(maxFields))
override def verboseString(maxFields: Int): String =
toString(super.verboseString(maxFields), maxFields)

override def simpleString(maxFields: Int): String = toString(super.simpleString(maxFields))

private def toString(original: String): String = {
original + ", [OUTPUT] " + output.map(attr => attr.name + ":" + attr.dataType).toString()
private def toString(original: String, maxFields: Int): String = {
original + ", [output=" + truncatedString(
output.map(_.verboseString(maxFields)),
"[",
", ",
"]",
maxFields) + "]"
}

override def output: Seq[Attribute] = if (projectOutputAttributes != null) {
Expand Down