Skip to content

[CORE] Optimize the verboseString of ColumnarShuffleExchangeExec#10846

Merged
zhztheplayer merged 1 commit intoapache:mainfrom
Zouxxyy:dev/update-shuffle-tostring
Oct 8, 2025
Merged

[CORE] Optimize the verboseString of ColumnarShuffleExchangeExec#10846
zhztheplayer merged 1 commit intoapache:mainfrom
Zouxxyy:dev/update-shuffle-tostring

Conversation

@Zouxxyy
Copy link
Contributor

@Zouxxyy Zouxxyy commented Oct 7, 2025

What changes are proposed in this pull request?

before:
ColumnarExchange SinglePartition, ENSURE_REQUIREMENTS, [plan_id=744], [shuffle_writer_type=hash], [OUTPUT] List(sum:DoubleType, count:LongType), [OUTPUT] List(sum:DoubleType, count:LongType)


after:
ColumnarExchange SinglePartition, ENSURE_REQUIREMENTS, [plan_id=710], [shuffle_writer_type=hash], [output=[sum#133: double, count#134: bigint]]

The reason why the OUTPUT appeared twice previously is that verboseString internally calls simpleString. Moreover, simpleString generally does not include output information, so this PR simply removes it.

How was this patch tested?

@github-actions github-actions bot added the CORE works for Gluten Core label Oct 7, 2025
@github-actions
Copy link

github-actions bot commented Oct 7, 2025

Run Gluten Clickhouse CI on x86

@Zouxxyy Zouxxyy changed the title [core] Optimize the verboseString of ColumnarShuffleExchangeExec [CORE] Optimize the verboseString of ColumnarShuffleExchangeExec Oct 7, 2025
@marin-ma
Copy link
Contributor

marin-ma commented Oct 7, 2025

Can we preserve the data type?

@github-actions
Copy link

github-actions bot commented Oct 7, 2025

Run Gluten Clickhouse CI on x86

1 similar comment
@github-actions
Copy link

github-actions bot commented Oct 7, 2025

Run Gluten Clickhouse CI on x86

@Zouxxyy Zouxxyy force-pushed the dev/update-shuffle-tostring branch from 2877232 to 632f1c4 Compare October 7, 2025 15:42
@github-actions
Copy link

github-actions bot commented Oct 7, 2025

Run Gluten Clickhouse CI on x86

Copy link
Contributor

@marin-ma marin-ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@zhztheplayer zhztheplayer merged commit 70380a2 into apache:main Oct 8, 2025
100 of 101 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CORE works for Gluten Core

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants