Skip to content

[GLUTEN-10810][VL] Change the default value of propagateIgnoreNullKeys to false #10811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
beliefer wants to merge 1 commit into from
Closed

[GLUTEN-10810][VL] Change the default value of propagateIgnoreNullKeys to false #10811

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion backends-velox/src/main/scala/org/apache/gluten/config/VeloxConfig.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -639,7 +639,7 @@ object VeloxConfig {
"on the grouping keys, and mark the ignoreNullKeys flag to true to " +
"avoid unnecessary aggregation on null keys.")
.booleanConf
.createWithDefault(true)
.createWithDefault(false)

val FLOATING_POINT_MODE =
buildConf("spark.gluten.sql.columnar.backend.velox.floatingPointMode")
Expand Down
4 changes: 3 additions & 1 deletion backends-velox/src/test/scala/org/apache/gluten/execution/VeloxAggregateFunctionsSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1203,7 +1203,9 @@ class VeloxAggregateFunctionsDefaultSuite extends VeloxAggregateFunctionsSuite {
| (select l_orderkey from lineitem) b
|on a.l_orderkey = b.l_orderkey
|""".stripMargin
withSQLConf(GlutenConfig.COLUMNAR_FORCE_SHUFFLED_HASH_JOIN_ENABLED.key -> "true") {
withSQLConf(
GlutenConfig.COLUMNAR_FORCE_SHUFFLED_HASH_JOIN_ENABLED.key -> "true",
VeloxConfig.VELOX_PROPAGATE_IGNORE_NULL_KEYS_ENABLED.key -> "true") {
runQueryAndCompare(s) {
df =>
val executedPlan = getExecutedPlan(df)
Expand Down