[GLUTEN-10810][VL] Change the default value of propagateIgnoreNullKeys to false#10811
Closed
beliefer wants to merge 1 commit intoapache:mainfrom
Closed
[GLUTEN-10810][VL] Change the default value of propagateIgnoreNullKeys to false#10811beliefer wants to merge 1 commit intoapache:mainfrom
beliefer wants to merge 1 commit intoapache:mainfrom
Conversation
Member
|
Perhaps we can add the issue / PR (#8966) that is related to this one in the PR description so people can track back on the history. |
Contributor
Author
|
@zhztheplayer Description updated. |
Contributor
Author
|
cc @jackylee-ch |
Contributor
Author
|
Because #10852 merged. I will close this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
This PR proposes to change the default value of
propagateIgnoreNullKeysto falseFixes #10810
issue (#8966) / PR (#8967) added the function that propagate
ignoreNullKeyswhen possible. But in our environment, I found this PR brings perf degradation.After e368a32, the benchmark TPC-DS SF1000, some cases occur perf degradation.
Before e368a32
After e368a32
How was this patch tested?
GA tests.