[VL] Delta: Add Delta Lake write unit test for Spark 3.5 + Delta 3.3#10802
Merged
zhztheplayer merged 6 commits intoapache:mainfrom Sep 26, 2025
Merged
[VL] Delta: Add Delta Lake write unit test for Spark 3.5 + Delta 3.3#10802zhztheplayer merged 6 commits intoapache:mainfrom
zhztheplayer merged 6 commits intoapache:mainfrom
Conversation
zhztheplayer
changed the title
|
Run Gluten Clickhouse CI on x86 |
zhztheplayer
commented
Sep 26, 2025
|
|
||
| val COLUMNAR_TABLE_CACHE_ENABLED = | ||
| buildConf("spark.gluten.sql.columnar.tableCache") | ||
| buildStaticConf("spark.gluten.sql.columnar.tableCache") |
Member
Author
There was a problem hiding this comment.
I suspect this option is somehow leaked among different test suites so caused some strange errors. Let's correct it as static to align with its life scope and doing this will also help diagnosing the issue.
|
Run Gluten Clickhouse CI on x86 |
zhztheplayer
force-pushed
the
wip-delta-write-ut
branch
from
c2b76da to
5c4bc75
Compare
|
Run Gluten Clickhouse CI on x86 |
1 similar comment
|
Run Gluten Clickhouse CI on x86 |
zhztheplayer
changed the title
zhouyuan
approved these changes
Sep 26, 2025
zhztheplayer
commented
Sep 26, 2025
Comment on lines
+39
to
+41
| // FIXME: Excluded by Gluten as results are mismatch. | ||
| "test delete on temp view - nontrivial projection - SQL TempView", | ||
| "test delete on temp view - nontrivial projection - Dataset TempView" |
Member
Author
There was a problem hiding this comment.
TODO: Fix these cases.
Comment on lines
+134
to
+136
| // FIXME: Excluded by Gluten as results are mismatch. | ||
| "test delete on temp view - nontrivial projection - SQL TempView", | ||
| "test delete on temp view - nontrivial projection - Dataset TempView" |
Member
Author
There was a problem hiding this comment.
TODO: Fix these cases.
Comment on lines
+98
to
+102
| // FIXME: Enable the test. | ||
| // Skipping as function input_file_name doesn't get correctly resolved. | ||
| @Ignore | ||
| class DeleteSQLNameColumnMappingSuite extends DeleteSQLSuite | ||
| with DeltaColumnMappingEnableNameMode { |
Member
Author
There was a problem hiding this comment.
TODO: Fix this suite.
zhztheplayer
force-pushed
the
wip-delta-write-ut
branch
from
4deeac9 to
aace47b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delta doesn't release its testing Jars so we copy-paste some of their test code here as a quick solution to test Gluten with Delta.
In long-term, we may consider releasing a Delta test jar ourselves, or adopting download-and-patching for the sources to avoid maintaining Delta's test code in our code base.
In this PR, we only introduce one single test suite
DeleteSQLSuitebut it will cover the main Delta write functionality. We will add more in the future.