Skip to content

Improve tracing #4384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
belliottsmith merged 1 commit into from
Oct 29, 2025
Merged

Improve tracing #4384

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/accord
Open in desktop
Submodule accord updated 52 files
+3 −1 accord-core/src/main/java/accord/api/Agent.java
+4 −0 accord-core/src/main/java/accord/api/CoordinatorEventListener.java
+0 −23 accord-core/src/main/java/accord/api/TraceEventType.java
+53 −34 accord-core/src/main/java/accord/api/Tracing.java
+3 −12 accord-core/src/main/java/accord/coordinate/AbstractCoordinatePreAccept.java
+26 −5 accord-core/src/main/java/accord/coordinate/AbstractCoordination.java
+7 −2 accord-core/src/main/java/accord/coordinate/AbstractSimpleCoordination.java
+5 −13 accord-core/src/main/java/accord/coordinate/AsynchronousAwait.java
+2 −22 accord-core/src/main/java/accord/coordinate/CheckShards.java
+3 −11 accord-core/src/main/java/accord/coordinate/CollectLatestDeps.java
+4 −4 accord-core/src/main/java/accord/coordinate/CoordinateEphemeralRead.java
+1 −1 accord-core/src/main/java/accord/coordinate/CoordinateMaxConflict.java
+4 −4 accord-core/src/main/java/accord/coordinate/CoordinatePreAccept.java
+3 −3 accord-core/src/main/java/accord/coordinate/CoordinateSyncPoint.java
+8 −14 accord-core/src/main/java/accord/coordinate/CoordinateTransaction.java
+14 −7 accord-core/src/main/java/accord/coordinate/Coordination.java
+3 −3 accord-core/src/main/java/accord/coordinate/ExecuteEphemeralRead.java
+7 −3 accord-core/src/main/java/accord/coordinate/ExecuteFlag.java
+3 −9 accord-core/src/main/java/accord/coordinate/ExecuteSyncPoint.java
+2 −3 accord-core/src/main/java/accord/coordinate/ExecuteTxn.java
+3 −9 accord-core/src/main/java/accord/coordinate/FetchCoordinator.java
+7 −11 accord-core/src/main/java/accord/coordinate/FetchData.java
+12 −7 accord-core/src/main/java/accord/coordinate/FetchRoute.java
+2 −2 accord-core/src/main/java/accord/coordinate/Infer.java
+10 −20 accord-core/src/main/java/accord/coordinate/Invalidate.java
+10 −14 accord-core/src/main/java/accord/coordinate/MaybeRecover.java
+6 −15 accord-core/src/main/java/accord/coordinate/Persist.java
+22 −25 accord-core/src/main/java/accord/coordinate/PrepareRecovery.java
+13 −30 accord-core/src/main/java/accord/coordinate/Propose.java
+37 −5 accord-core/src/main/java/accord/coordinate/ReadCoordinator.java
+51 −68 accord-core/src/main/java/accord/coordinate/Recover.java
+9 −18 accord-core/src/main/java/accord/coordinate/Stabilise.java
+3 −12 accord-core/src/main/java/accord/coordinate/SynchronousAwait.java
+2 −3 accord-core/src/main/java/accord/coordinate/SynchronousRecoverAwait.java
+4 −8 accord-core/src/main/java/accord/impl/progresslog/HomeState.java
+21 −19 accord-core/src/main/java/accord/impl/progresslog/WaitingState.java
+2 −4 accord-core/src/main/java/accord/local/Command.java
+0 −1 accord-core/src/main/java/accord/local/CommandStores.java
+7 −0 accord-core/src/main/java/accord/local/MapReduceCommandStores.java
+3 −10 accord-core/src/main/java/accord/local/Node.java
+12 −0 accord-core/src/main/java/accord/local/SafeCommand.java
+5 −0 accord-core/src/main/java/accord/local/StoreParticipants.java
+0 −14 accord-core/src/main/java/accord/messages/GetMaxConflict.java
+1 −9 accord-core/src/main/java/accord/messages/ParticipantsRequest.java
+3 −2 accord-core/src/main/java/accord/messages/Propagate.java
+1 −4 accord-core/src/main/java/accord/messages/RouteRequest.java
+1 −1 accord-core/src/main/java/accord/primitives/Routable.java
+11 −2 accord-core/src/main/java/accord/primitives/Txn.java
+2 −2 accord-core/src/main/java/accord/primitives/TxnId.java
+85 −10 accord-core/src/main/java/accord/utils/TinyEnumSet.java
+52 −0 accord-core/src/test/java/accord/api/TracingTest.java
+5 −3 accord-core/src/test/java/accord/impl/list/ListAgent.java
561 changes: 474 additions & 87 deletions src/java/org/apache/cassandra/db/virtual/AccordDebugKeyspace.java
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 0 additions & 2 deletions src/java/org/apache/cassandra/metrics/AccordCoordinatorMetrics.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,8 +198,6 @@ public String toString()

public static class Listener implements CoordinatorEventListener
{
public static final Listener instance = new Listener();

private AccordCoordinatorMetrics forTransaction(TxnId txnId)
{
if (txnId != null)
Expand Down
2 changes: 0 additions & 2 deletions src/java/org/apache/cassandra/metrics/AccordReplicaMetrics.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,8 +112,6 @@ public String toString()

public static class Listener implements ReplicaEventListener
{
public static final Listener instance = new Listener();

private AccordReplicaMetrics forTransaction(TxnId txnId)
{
if (txnId != null)
Expand Down
4 changes: 4 additions & 0 deletions src/java/org/apache/cassandra/metrics/AccordSystemMetrics.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,10 @@ static class SnapshotBuilder
}
}

public static void touch()
{
}

private AccordSystemMetrics()
{
Invariants.expect(AccordService.isSetup());
Expand Down
2 changes: 2 additions & 0 deletions src/java/org/apache/cassandra/service/accord/AccordService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
import accord.api.ConfigurationService.EpochReady;
import accord.primitives.Txn;
import org.apache.cassandra.metrics.AccordReplicaMetrics;
import org.apache.cassandra.metrics.AccordSystemMetrics;
import org.apache.cassandra.service.accord.api.AccordViolationHandler;
import org.apache.cassandra.utils.Clock;
import org.apache.cassandra.utils.concurrent.AsyncFuture;
Expand Down Expand Up @@ -307,6 +308,7 @@ public synchronized static AccordService startup(NodeId tcmId)
instance = as;

AccordReplicaMetrics.touch();
AccordSystemMetrics.touch();
AccordViolationHandler.setup();

WatermarkCollector.fetchAndReportWatermarksAsync(as.configService);
Expand Down
Loading