Skip to content

Conversation

@belliottsmith
Copy link
Contributor

Thanks for sending a pull request! Here are some tips if you're new here:

  • Ensure you have added or run the appropriate tests for your PR.
  • Be sure to keep the PR description updated to reflect all changes.
  • Write your PR title to summarize what this PR proposes.
  • If possible, provide a concise example to reproduce the issue for a faster review.
  • Read our contributor guidelines
  • If you're making a documentation change, see our guide to documentation contribution

Commit messages should follow the following format:

<One sentence description, usually Jira title or CHANGES.txt summary>

<Optional lengthier description (context on patch)>

patch by <Authors>; reviewed by <Reviewers> for CASSANDRA-#####

Co-authored-by: Name1 <email1>
Co-authored-by: Name2 <email2>

The Cassandra Jira

@ifesdjeen
Copy link
Contributor

I hope this is not too confusing: as of moment of writing this, Improve Tracing (this) PR contains multiple commits, starting with rebootstrap. To make review simpler to track, I have made a separate PR where only tracing commit is displayed: belliottsmith#8 My (minor) comments are on the PR.

@ifesdjeen ifesdjeen self-requested a review September 26, 2025 09:08
Copy link
Contributor

@ifesdjeen ifesdjeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 as long as critical comments in belliottsmith#8 are either addressed or explained (in case my assumptions were wrong).

@belliottsmith belliottsmith force-pushed the improve-tracing branch 7 times, most recently from baa8f18 to 0ec190b Compare October 29, 2025 09:49
     - Introduce pattern tracing, that can intercept failed or new coordinations matching various filters
     - Support additional tracing event collection modes (SAMPLE and RING)

    patch by Benedict; reviewed by Alex Petrov for CASSANDRA-20911
@belliottsmith belliottsmith merged commit e768418 into apache:trunk Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants