sandbox: Do not silently drop platform properties#2013
Merged
Conversation
For remote execution, there is currently no way to determine what platform properties are supported. Silently dropping platform properties that may or may not be supported can result in build behavior differences or confusing errors. This code was originally added before the `build-uid` and `build-gid` sandbox configuration was made optional to not break remote execution. However, now that the corresponding platform properties are only set if requested by the project or element, it's better to fail the build than to ignore the setting.
juergbi
requested review from
BenjaminSchubert,
abderrahim,
cs-shadow and
gtristan
as code owners
abderrahim
approved these changes
May 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For remote execution, there is currently no way to determine what platform properties are supported. Silently dropping platform properties that may or may not be supported can result in build behavior differences or confusing errors.
This code was originally added before the
build-uidandbuild-gidsandbox configuration was made optional to not break remote execution. However, now that the corresponding platform properties are only set if requested by the project or element, it's better to fail the build than to ignore the setting.