Add support for REAPI execution from the sandbox#2014
Conversation
a045d16 to
b52065e
Compare
|
I tested this, and recc inside the sandbox is complaining I dug a bit and it is due to the fact that I'm using a cache storage service. Disabling it works fine. |
|
Generally like this patch overall... although it is still in draft, do we want this in 2.5 ? Should we add an integration test for exercising I'd be happy to add a tested example based on the recc demo to sweeten the pot if we think we're ready to go ahead with this... |
|
I feel it's still not ready. While it's good enough, I'd say let's leave it till 2.6. I think that's also @juergbi's opinion as this is still marked as draft. |
|
Leaving it till 2.6 is fine with me. I anyway expect typical use cases to require #1991 and that's also still a draft. |
b52065e to
06e3efc
Compare
I've added a check for this to fail the build with a clear error message. In https://github.com/apache/buildstream/tree/jbilleter/action-cache-service, I'm adding support for I've also added a minimal test to this branch. CI is currently failing due to BuildBox being too old for the added test. #2023 updates the CI images based on https://gitlab.com/BuildStream/buildstream-docker-images/-/merge_requests/230. |
tests/integration/project/elements/sandbox/remote-apis-socket.bst
Outdated
Show resolved
Hide resolved
Yeah, this is fine. With the clear error message here, we can land this even if it doesn't support the cache storage-service. I'll test the action-cache-service branch in the mean time |
This bumps the minimum version of buildbox-casd to 1.2.0.
06e3efc to
a452797
Compare
a452797 to
c78a184
Compare
| _REQUIRED_CASD_MINOR = 0 | ||
| _REQUIRED_CASD_MICRO = 58 | ||
| _REQUIRED_CASD_MAJOR = 1 | ||
| _REQUIRED_CASD_MINOR = 2 |
There was a problem hiding this comment.
I think we can have some cleanups of fallback code paths now that we require buildbox 1.2. That shouldn't block this pull request, but it should be nice to have it done before the next release.
Fixes #1985.