Fix: Unpin google-cloud-bigtable version in BeamModulePlugin#37688
Fix: Unpin google-cloud-bigtable version in BeamModulePlugin#37688junaiddshaukat wants to merge 1 commit intoapache:masterfrom
Conversation
Summary of ChangesHello @junaiddshaukat, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines dependency management for Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Per #37637 (comment) we can't take this change yet |
Rationale for this change
This PR addresses issue #37637 by removing the manual version pin for
google-cloud-bigtableinBeamModulePlugin.groovy. The version was previously pinned to2.73.1due to a BOM update lag, but it should now be managed by thegoogle_cloud_platform_libraries_bom(currently providing2.73.0) as intended.Major changes
def bigtable_version = "2.73.1"google_cloud_bigtableto use the managed version from the BOM instead of the explicit variable.Result
The
google-cloud-bigtabledependency version will now be automatically managed by the BOM, simplifying dependency management and ensuring consistency with other Google Cloud libraries.Fixes: #37637
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.