Skip to content

Fix flakiness in model manager and multiprocessshared tests #37529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
damccorm merged 3 commits into from
Feb 6, 2026
Merged

Fix flakiness in model manager and multiprocessshared tests #37529

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fdd2c55
Fix flakes
AMOOOMA Feb 6, 2026
a9d0c44
Merge branch 'apache:master' into flake
AMOOOMA Feb 6, 2026
dfb0f35
Don't use the same tag twice
AMOOOMA Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions sdks/python/apache_beam/ml/inference/model_manager_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,22 +333,21 @@ def test_single_model_convergence_with_fluctuations(self):
"""
model_name = "fluctuating_model"
model_cost = 3000.0
load_cost = 2500.0
# Fix random seed for reproducibility
random.seed(42)

def loader():
self.mock_monitor.allocate(load_cost)
self.mock_monitor.allocate(model_cost)
return model_name

model = self.manager.acquire_model(model_name, loader)
self.manager.release_model(model_name, model)
initial_est = self.manager._estimator.get_estimate(model_name)
self.assertEqual(initial_est, load_cost)
self.assertEqual(initial_est, model_cost)

def run_inference():
model = self.manager.acquire_model(model_name, loader)
noise = model_cost - load_cost + random.uniform(-300.0, 300.0)
noise = random.uniform(-300.0, 300.0)
self.mock_monitor.allocate(noise)
time.sleep(0.1)
self.mock_monitor.free(noise)
Expand Down
6 changes: 4 additions & 2 deletions sdks/python/apache_beam/utils/multi_process_shared_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,6 +289,7 @@ def setUp(self):
for tag in ['basic',
'main',
'to_delete',
'to_keep',
'mix1',
'mix2',
'test_process_exit',
Expand All @@ -310,7 +311,7 @@ def tearDown(self):

def test_call(self):
shared = multi_process_shared.MultiProcessShared(
Counter, tag='basic', always_proxy=True, spawn_process=True).acquire()
Counter, tag='main', always_proxy=True, spawn_process=True).acquire()
self.assertEqual(shared.get(), 0)
self.assertEqual(shared.increment(), 1)
self.assertEqual(shared.increment(10), 11)
Expand All @@ -323,7 +324,8 @@ def test_unsafe_hard_delete_autoproxywrapper(self):
shared2 = multi_process_shared.MultiProcessShared(
Counter, tag='to_delete', always_proxy=True, spawn_process=True)
counter3 = multi_process_shared.MultiProcessShared(
Counter, tag='basic', always_proxy=True, spawn_process=True).acquire()
Counter, tag='to_keep', always_proxy=True,
spawn_process=True).acquire()

counter1 = shared1.acquire()
counter2 = shared2.acquire()
Expand Down
Loading