Fix flakiness in model manager and multiprocessshared tests

[AMOOOMA]

Fix flakiness

---

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
• Update CHANGES.md with noteworthy changes.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

[gemini-code-assist]

Summary of Changes

Hello @AMOOOMA, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses flakiness in two distinct test suites within the Apache Beam Python SDK. It refines the model cost estimation logic in the model manager tests to ensure consistent behavior and updates a shared resource tag in the multi-process utility tests, both aimed at improving test reliability.

Highlights

• Model Manager Test Refinement: Simplified cost calculation logic in model_manager_test.py by removing a redundant load_cost variable and directly using model_cost for allocation and assertion, which likely resolves a source of test flakiness.
• Multi-Process Shared Test Tag Update: Updated a tag name from 'basic' to 'main' for a MultiProcessShared instance in multi_process_shared_test.py, addressing potential flakiness or naming inconsistencies.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• sdks/python/apache_beam/ml/inference/model_manager_test.py
  • Removed the load_cost variable and updated its references to use model_cost directly within the test_single_model_convergence_with_fluctuations method.
  • Modified the noise calculation in the same test to align with the simplified cost logic.
• sdks/python/apache_beam/utils/multi_process_shared_test.py
  • Changed the tag argument for a MultiProcessShared instance from 'basic' to 'main' in the test_unsafe_hard_delete_autoproxywrapper method.

Activity

• The author, AMOOOMA, created this pull request to fix flakiness in tests.
• No specific human activity (comments, reviews, or progress updates) has been recorded in the provided context.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[github-actions]

Assigning reviewers:

R: @tvalentyn for label python.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

• stop reviewer notifications - opt out of the automated review tooling
• remind me after tests pass - tag the comment author after tests pass
• waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

[damccorm]

I noticed that https://github.com/apache/beam/actions/runs/21735905959/job/62700799352?pr=37529 is failing as well, I'm guessing for basically the same reason. Both test_call and MultiProcessSharedTest.setUpClass rely on the 'basic' tag, I think these should be changed to be different as well

[AMOOOMA]

Ah yes, that makes sense, I will update it to a completely unique tag thanks!

[damccorm]

R: @damccorm

[github-actions]

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

[damccorm]

There were a few flakes unrelated to your changes. Rerunning tests, but otherwise this LGTM