[2/3] sdks/python: enrich data with Milvus Search [Vector, Keyword, Hybrid]#35577
[2/3] sdks/python: enrich data with Milvus Search [Vector, Keyword, Hybrid]#35577damccorm merged 14 commits intoapache:masterfrom
Conversation
92548cd to
ad0a4d4
Compare
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
ad0a4d4 to
e8d9659
Compare
|
Assigning reviewers: R: @claudevdm for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
stop reviewer notifications |
|
Stopping reviewer notifications for this pull request: requested by reviewer. If you'd like to restart, comment |
c7997fa to
f4e836b
Compare
89f4319 to
c83a849
Compare
e8bba02 to
f9de00b
Compare
365f2a3 to
538adff
Compare
602a313 to
0af2934
Compare
0af2934 to
94f8f72
Compare
|
Hey @damccorm, I haven't experimented with this yet and not sure about the feasibility of this suggestion I think if we update the ubuntu version to latest for self-hosted runners it would probably solve this docker_in_docker environment issue entirely and may be future related issues The minimum recommend ubuntu version for docker to run stably is I am still uncertain if there are beam related dependencies in the CI testing environment that depends on the existing ubuntu version What do you think? cc @Abacn (may help here as well – it is related to infra) EDIT: |
damccorm
left a comment
There was a problem hiding this comment.
This LGTM - I'm going to let tests run to try to get a green signal and then I'll merge if they don't raise any real problems
…ybrid] (apache#35577) * sdks/python: mark `milvus` as extra dependency * sdks/python: mark milvus itests with `require_docker_in_docker` * .github: trigger postcommit python * .github: trigger postcommit python * .github: trigger postcommit python * sdks/python: fix linting issues * .github: update beam postcommit python * sdks/python: fix linting issues * workflows: trigger postcommit python * sdks/python: update image requirements * workflows: trigger postcommit python
Description
Milvusas extra dependencyMilvusitests asrequire_docker_in_dockerto runubuntu-latestTowards #35046.
Prev #35216.
Next #35467.
Motivation and Context
Follow-up on the discussion here #35216 (comment).
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.UpdateCHANGES.mdwith noteworthy changes.If this contribution is large, please file an Apache Individual Contributor License Agreement.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.