workflows+gradle: capture and run ML tests that require non self-hosted environment on ubuntu-latest#35585
Merged
damccorm merged 6 commits intoapache:masterfrom Jul 15, 2025
Conversation
ubuntu-latest
ubuntu-latestubuntu-latest
Contributor
Author
|
cc @damccorm for thoughts and feedback on this approach 🙏 PS: |
Contributor
|
Assigning reviewers: R: @liferoad for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
damccorm
reviewed
Jul 14, 2025
Contributor
damccorm
left a comment
There was a problem hiding this comment.
Thanks - the approach looks good, just had some minor doc suggestions
Co-authored-by: Danny McCormick <dannymccormick@google.com>
damccorm
approved these changes
Jul 14, 2025
Contributor
damccorm
left a comment
There was a problem hiding this comment.
Thanks! I'll merge after checks complete
Abacn
reviewed
Jul 14, 2025
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Handle ML tests that can't run on self-hosted runners mainly due to Docker-in-Docker environment limitations or other operational constraints by:
require_non_self_hostedpytest markerrequire_non_self_hostedusingnonSelfHostedIntegrationTestgradle tasknonSelfHostedIntegrationTestcapture task to Postcommit Itests to runbeam_PostCommit_Pythonandbeam_PreCommit_Python_MLto conditionally run test cases that require non-self hosted environment if any onubuntu-latestGitHub hosted runnerWe could follow an incremental approach here for running tests that require non self-hosted environmnet, targeting specific workflows as needed. For example, the current implementation addresses the dependent PR related to Milvus integration, which requires a non-self-hosted environment for ML testing.
Dependency for #35577
Motivation and Context
Follow-up on the discussion here #35216 (comment).
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.UpdateCHANGES.mdwith noteworthy changes.If this contribution is large, please file an Apache Individual Contributor License Agreement.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.