-
Notifications
You must be signed in to change notification settings - Fork 4k
GH-48013: [R] Add CI job for musl (Alpine Linux) to replicate CRAN checks #48014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
|
@github-actions crossbow submit test-r-alpine-linux Testing the CI job without the nixlibs change first... |
|
Revision: ab2dbc9 Submitted crossbow builds: ursacomputing/crossbow @ actions-75a7216cba
|
ab2dbc9 to
4b110a1
Compare
|
@github-actions crossbow submit test-r-alpine-linux |
|
|
@github-actions crossbow submit test-r-alpine-linux |
|
Revision: ae89e8b Submitted crossbow builds: ursacomputing/crossbow @ actions-2bcbb2c1d0
|
|
@github-actions crossbow submit test-r-alpine-linux |
|
Revision: 97dd549 Submitted crossbow builds: ursacomputing/crossbow @ actions-5ba8e7e3d4
|
|
@github-actions crossbow submit test-r-alpine-linux |
|
Revision: f1daf26 Submitted crossbow builds: ursacomputing/crossbow @ actions-edaae374e2
|
|
Latest failure: So next we just need to update that script to use whatever Alpine Linux uses as a package manager |
53116cb to
0e3a348
Compare
|
@github-actions crossbow submit test-r-alpine-linux |
|
Revision: 0e3a348 Submitted crossbow builds: ursacomputing/crossbow @ actions-c2627c1668
|
|
@github-actions crossbow submit test-r-alpine-linux |
|
Revision: 22fadf7 Submitted crossbow builds: ursacomputing/crossbow @ actions-f5214c8c49
|
|
@github-actions crossbow submit test-r-alpine-linux |
|
Revision: c45e0f7 Submitted crossbow builds: ursacomputing/crossbow @ actions-70688aa0b2
|
|
@github-actions crossbow submit test-r-alpine-linux-cran |
|
Revision: b4f611c Submitted crossbow builds: ursacomputing/crossbow @ actions-65f1d7dddc
|
|
Never mind, we had some missing parentheses in one of our test scripts on CI. Good catch spotting that it shouldn't be doing that, have updated now! |
|
@github-actions crossbow submit test-r-alpine-linux-cran |
|
Revision: 9a81605 Submitted crossbow builds: ursacomputing/crossbow @ actions-4156adbfba
|
|
If you get a segfault when reticulate loads python then this is probably from a known numpy/openblas bug (rstudio/reticulate#1858), which you could work around by setting environment variable |
ci/scripts/r_test.sh
Outdated
| } | ||
| if (!as_cran && requireNamespace('reticulate', quietly = TRUE) && reticulate::py_module_available('pyarrow')) { | ||
| if (!as_cran && (requireNamespace('reticulate', quietly = TRUE)) && reticulate::py_module_available('pyarrow')) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand the added parentheses here, they shouldn't make a difference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm...they don't - I tried it locally before/after, and whatever was invoking a Python module install must have succeeded when I ran the "before" version, and so when I ran it again "after", I conflated the change in the environment (and thus no console output) with the code change working.
|
Right, we need to manually set |
|
@github-actions crossbow submit test-r-alpine-linux-cran |
|
Revision: 5fa4d16 Submitted crossbow builds: ursacomputing/crossbow @ actions-bb37eb6094
|
…ecks (#48014) ### Rationale for this change CRAN have added Alpine Linux to their additional jobs - we should make sure we can test for this on CI ### What changes are included in this PR? Add CI job for Alpine Linux ### Are these changes tested? Yeah, the CI job should pass ### Are there any user-facing changes? No * GitHub Issue: #48013 Authored-by: Nic Crane <thisisnic@gmail.com> Signed-off-by: Nic Crane <thisisnic@gmail.com>
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 5de6aa6. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 20 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
CRAN have added Alpine Linux to their additional jobs - we should make sure we can test for this on CI
What changes are included in this PR?
Add CI job for Alpine Linux
Are these changes tested?
Yeah, the CI job should pass
Are there any user-facing changes?
No