Fix union cast incorrectness for duplicate field names#9666
Merged
alamb merged 1 commit intoapache:mainfrom Apr 10, 2026
Merged
Fix union cast incorrectness for duplicate field names#9666alamb merged 1 commit intoapache:mainfrom
alamb merged 1 commit intoapache:mainfrom
Conversation
friendlymatthew
force-pushed
the
friendlymatthew/use-type-id-union-extract
branch
from
ec614b0 to
6766220
Compare
alamb
approved these changes
Apr 10, 2026
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you @friendlymatthew
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
This PR fixes
union_extract_by_typeto select children by type id instead of field nameunion_extractresolves children by field name, greedily returning the first match. Whenunion_extract_by_typeresolved the correct child via type and then calledunion_extractwith just the field name, that name-based lookup could pick the wrong child if another field shared the same nameThis commit exposes a public method
union_extract_by_idthat selects the child by type id directly. This way, it avoids the ambiguity mentioned above