Skip to content

Rename CreationViewModel.startClicked to onStartClicked #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
riggaroo merged 2 commits into from
Oct 13, 2025
+12 −12
Merged

Rename CreationViewModel.startClicked to onStartClicked #161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f545b31
Rename startClicked to onStartClicked
takahirom Oct 11, 2025
2730419
Rename tests
takahirom Oct 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion feature/creation/src/main/java/com/android/developers/androidify/creation/CreationScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ fun CreationScreen(
onUndoPressed = creationViewModel::onUndoPressed,
onPromptGenerationPressed = creationViewModel::onPromptGenerationClicked,
onBotColorSelected = creationViewModel::onBotColorChanged,
onStartClicked = creationViewModel::startClicked,
onStartClicked = creationViewModel::onStartClicked,
onDropCallback = creationViewModel::onImageSelected,
)
}
Expand Down
2 changes: 1 addition & 1 deletion ...re/creation/src/main/java/com/android/developers/androidify/creation/CreationViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ class CreationViewModel @AssistedInject constructor(
}
}

fun startClicked() {
fun onStartClicked() {
imageGenerationJob?.cancel()
imageGenerationJob = viewModelScope.launch {
if (internetConnectivityManager.isInternetAvailable()) {
Expand Down
20 changes: 10 additions & 10 deletions ...ation/src/test/kotlin/com/android/developers/androidify/creation/CreationViewModelTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ class CreationViewModelTest {
}

@Test
fun startClicked_GenerateBotFromPhoto() = runTest {
fun onStartClicked_GenerateBotFromPhoto() = runTest {
val screenStateValues = mutableListOf<ScreenState>()
backgroundScope.launch(UnconfinedTestDispatcher()) {
viewModel.uiState.collect {
Expand All @@ -140,13 +140,13 @@ class CreationViewModelTest {

viewModel.onImageSelected(Uri.parse("content://test/image.jpg"))
viewModel.onSelectedPromptOptionChanged(PromptType.PHOTO)
viewModel.startClicked()
viewModel.onStartClicked()
assertEquals(ScreenState.EDIT, viewModel.uiState.value.screenState)
assertNotNull(viewModel.uiState.value.resultBitmapUri)
}

@Test
fun startClicked_GenerateBotFromPhoto_NoPhotoSelected() = runTest {
fun onStartClicked_GenerateBotFromPhoto_NoPhotoSelected() = runTest {
val values = mutableListOf<SnackbarHostState>()

backgroundScope.launch(UnconfinedTestDispatcher()) {
Expand All @@ -156,7 +156,7 @@ class CreationViewModelTest {
}

viewModel.onSelectedPromptOptionChanged(PromptType.PHOTO)
viewModel.startClicked()
viewModel.onStartClicked()
assertEquals(ScreenState.EDIT, viewModel.uiState.value.screenState)
assertNotNull(
"Choose an image or use a prompt instead.",
Expand All @@ -165,7 +165,7 @@ class CreationViewModelTest {
}

@Test
fun startClicked_GenerateBotFromPrompt_TextEmpty() = runTest {
fun onStartClicked_GenerateBotFromPrompt_TextEmpty() = runTest {
val values = mutableListOf<SnackbarHostState>()

backgroundScope.launch(UnconfinedTestDispatcher()) {
Expand All @@ -182,7 +182,7 @@ class CreationViewModelTest {
imageGenerationRepository.exceptionToThrow = InsufficientInformationException()

viewModel.onSelectedPromptOptionChanged(PromptType.TEXT)
viewModel.startClicked()
viewModel.onStartClicked()

assertEquals(ScreenState.EDIT, screenStateValues[1])
assertEquals(
Expand All @@ -193,7 +193,7 @@ class CreationViewModelTest {
}

@Test
fun startClicked_GenerateBotFromPrompt() = runTest {
fun onStartClicked_GenerateBotFromPrompt() = runTest {
val screenStateValues = mutableListOf<ScreenState>()
backgroundScope.launch(UnconfinedTestDispatcher()) {
viewModel.uiState.collect {
Expand All @@ -204,21 +204,21 @@ class CreationViewModelTest {
viewModel.uiState.value.descriptionText.edit {
"testing input description"
}
viewModel.startClicked()
viewModel.onStartClicked()
assertEquals(ScreenState.EDIT, viewModel.uiState.value.screenState)
assertNotNull(viewModel.uiState.value.resultBitmapUri)
}

@Test
fun startClicked_NoInternet_DisplaysError() = runTest {
fun onStartClicked_NoInternet_DisplaysError() = runTest {
val values = mutableListOf<SnackbarHostState>()
backgroundScope.launch(UnconfinedTestDispatcher()) {
viewModel.snackbarHostState.collect {
values.add(it)
}
}
internetConnectivityManager.internetAvailable = false
viewModel.startClicked()
viewModel.onStartClicked()
advanceUntilIdle()
assertEquals(ScreenState.EDIT, viewModel.uiState.value.screenState)
assertEquals(
Expand Down