Skip to content

Conversation

@takahirom
Copy link
Contributor

Thanks for this awesome reference app!

I noticed a small naming inconsistency while reading through the code, so I've updated it.

Renamed CreationViewModel.startClickedonStartClicked to align with other event handler naming conventions (onUndoPressed, onPromptGenerationClicked, etc.).

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @takahirom, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving code consistency and readability by refactoring a key event handler's name. The startClicked function in CreationViewModel has been renamed to onStartClicked to align with established naming conventions for event callbacks. This change, while purely a refactor, enhances the maintainability and clarity of the codebase by ensuring a uniform approach to naming interactive elements, without altering any functional behavior. The update includes changes in the UI layer and associated unit tests.

Highlights

  • Naming Convention Alignment: The startClicked function within CreationViewModel has been renamed to onStartClicked to ensure consistency with other event handler naming conventions, such as onUndoPressed and onPromptGenerationClicked.
  • Call Site Updates: All references and call sites for the startClicked function in CreationScreen.kt have been updated to reflect the new onStartClicked name.
  • Test Case Refactoring: Corresponding test methods and their internal calls within CreationViewModelTest.kt have been refactored to use the new onStartClicked naming, maintaining test coverage and clarity.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly renames startClicked to onStartClicked to improve naming consistency for event handlers, and applies this change across the view model, screen, and tests. The change is well-motivated and implemented correctly. I've added a few suggestions to improve the tests you've touched, pointing out some existing issues like unused variables and incorrect assertions that you might want to fix while you're at it.

Copy link
Collaborator

@riggaroo riggaroo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix!

@riggaroo riggaroo merged commit 6f3eb8c into android:main Oct 13, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants