-
Notifications
You must be signed in to change notification settings - Fork 264
Rename CreationViewModel.startClicked to onStartClicked #161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @takahirom, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on improving code consistency and readability by refactoring a key event handler's name. The Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly renames startClicked to onStartClicked to improve naming consistency for event handlers, and applies this change across the view model, screen, and tests. The change is well-motivated and implemented correctly. I've added a few suggestions to improve the tests you've touched, pointing out some existing issues like unused variables and incorrect assertions that you might want to fix while you're at it.
...creation/src/test/kotlin/com/android/developers/androidify/creation/CreationViewModelTest.kt
Show resolved
Hide resolved
...creation/src/test/kotlin/com/android/developers/androidify/creation/CreationViewModelTest.kt
Show resolved
Hide resolved
...creation/src/test/kotlin/com/android/developers/androidify/creation/CreationViewModelTest.kt
Show resolved
Hide resolved
riggaroo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the fix!
Thanks for this awesome reference app!
I noticed a small naming inconsistency while reading through the code, so I've updated it.
Renamed
CreationViewModel.startClicked→onStartClickedto align with other event handler naming conventions (onUndoPressed,onPromptGenerationClicked, etc.).