-
Notifications
You must be signed in to change notification settings - Fork 1
docs: improve setup instructions and standardize port configuration #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -15,7 +15,7 @@ const FRONTEND_URL = process.env.FRONTEND_URL || 'http://localhost:5173'; | |||||||||||||||||
|
|
||||||||||||||||||
| // Middleware | ||||||||||||||||||
| app.use(cors({ | ||||||||||||||||||
| origin: [FRONTEND_URL, 'http://localhost:3000', 'http://localhost:5173'], | ||||||||||||||||||
| origin: [FRONTEND_URL, 'http://localhost:5173'], | ||||||||||||||||||
| credentials: true | ||||||||||||||||||
| })); // Allow requests from multiple frontend ports | ||||||||||||||||||
|
||||||||||||||||||
| })); // Allow requests from multiple frontend ports | |
| })); |
Copilot
AI
Dec 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The CORS origin array includes both FRONTEND_URL (which defaults to 'http://localhost:5173') and the hardcoded 'http://localhost:5173'. This creates redundancy when FRONTEND_URL is not explicitly set. Consider simplifying to just origin: FRONTEND_URL or keeping the array format only if multiple origins are genuinely needed for different deployment scenarios.
| origin: [FRONTEND_URL, 'http://localhost:5173'], | |
| credentials: true | |
| })); // Allow requests from multiple frontend ports | |
| origin: FRONTEND_URL, | |
| credentials: true | |
| })); // Allow requests from the frontend URL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] This note is a single, very long sentence that's difficult to read. Consider breaking it into multiple sentences or using a bulleted list for better readability. For example:
"Note: For the backend to start successfully, you must set the GitHub OAuth environment variables in
backend/.env:GITHUB_CLIENT_IDGITHUB_CLIENT_SECRETIf these are not present, the authentication routes will fail and the app may not start depending on your local configuration."