Skip to content

Assign cards to TODO: comments #2078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DavidBiddle wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Assign cards to TODO: comments #2078

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions infra/deployments/forms/pipelines/apply-terraform.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ resource "aws_codepipeline" "apply_terroform" {
FullRepositoryId = "govuk-forms/forms-e2e-tests"
BranchName = "main"
# TODO: we should version this repository appropriately, so we can pick specific versions
# https://trello.com/c/CboxmYA2/3452-version-forms-e2e-tests-so-we-can-pick-specific-versions
Copy link
Copy Markdown
Member

@lfdebrux lfdebrux Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we actually want to do this... we don't version our apps, why would the end to end tests be different?

Copy link
Copy Markdown
Contributor Author

@DavidBiddle DavidBiddle Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sarah added some context to the card, it sounds like it might have some benefits for predictability but it's not a big priority at the moment

DetectChanges = false
OutputArtifactFormat = "CODEBUILD_CLONE_REF"
}
Expand Down
1 change: 1 addition & 0 deletions infra/deployments/forms/pipelines/deploy-forms-admin-container.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,7 @@ resource "aws_codepipeline" "deploy_admin_container" {
FullRepositoryId = "govuk-forms/forms-e2e-tests"
BranchName = "main"
# TODO: we should version this repository appropriately, so we can pick specific versions
# https://trello.com/c/CboxmYA2/3452-version-forms-e2e-tests-so-we-can-pick-specific-versions
DetectChanges = false
OutputArtifactFormat = "CODEBUILD_CLONE_REF"
}
Expand Down
1 change: 1 addition & 0 deletions infra/deployments/forms/pipelines/deploy-forms-product-page-container.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,7 @@ resource "aws_codepipeline" "deploy_product_pages_container" {
FullRepositoryId = "govuk-forms/forms-e2e-tests"
BranchName = "main"
# TODO: we should version this repository appropriately, so we can pick specific versions
# https://trello.com/c/CboxmYA2/3452-version-forms-e2e-tests-so-we-can-pick-specific-versions
DetectChanges = false
OutputArtifactFormat = "CODEBUILD_CLONE_REF"
}
Expand Down
1 change: 1 addition & 0 deletions infra/deployments/forms/pipelines/deploy-forms-runner-container.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,7 @@ resource "aws_codepipeline" "deploy_runner_container" {
FullRepositoryId = "govuk-forms/forms-e2e-tests"
BranchName = "main"
# TODO: we should version this repository appropriately, so we can pick specific versions
# https://trello.com/c/CboxmYA2/3452-version-forms-e2e-tests-so-we-can-pick-specific-versions
DetectChanges = false
OutputArtifactFormat = "CODEBUILD_CLONE_REF"
}
Expand Down
2 changes: 2 additions & 0 deletions infra/modules/deployer-access/manage-environment-policy.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ data "aws_iam_policy_document" "acm_cert_with_dns_validation" {
]
resources = [
# TODO: Why does it need both regions?
# https://trello.com/c/enOX8GRF/3454-investigate-why-policy-document-acmcertwithdnsvalidation-needs-access-to-both-eu-west-2-and-us-east-1
"arn:aws:acm:eu-west-2:${var.account_id}:certificate/*",
"arn:aws:acm:us-east-1:${var.account_id}:certificate/*"
]
Expand Down Expand Up @@ -104,6 +105,7 @@ data "aws_iam_policy_document" "cloudfront" {
"wafv2:*RegexPatternSet",
]
# TODO: The scope of this should be cloudfront but for some reason it needs global
# https://trello.com/c/JCyMcRip/3455-investigate-why-managewafv2webacl-needs-global-scope-instead-of-just-cloudfront
resources = [
"arn:aws:wafv2:us-east-1:${var.account_id}:global/webacl/cloudfront_waf_${var.environment_name}/*",
"arn:aws:wafv2:eu-west-2:${var.account_id}:regional/webacl/alb_${var.environment_name}/*",
Expand Down
2 changes: 1 addition & 1 deletion infra/modules/deployer-access/policy.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,7 +348,7 @@ data "aws_iam_policy_document" "ses" {
"sns:UntagResource",
]
resources = [
"arn:aws:sns:eu-west-2:${var.account_id}:ses_bounces_and_complaints", # TODO: remove me once all envs use the new queues
"arn:aws:sns:eu-west-2:${var.account_id}:ses_bounces_and_complaints", # TODO: remove me once all envs use the new queues https://trello.com/c/BCDU9U7N/3456-remove-sesbouncesandcomplaints-sns-resource-if-all-environments-are-using-the-new-queues
"arn:aws:sns:eu-west-2:${var.account_id}:auth0_ses_bounces_and_complaints",
"arn:aws:sns:eu-west-2:${var.account_id}:submission_email_ses_bounces_and_complaints",
"arn:aws:sns:eu-west-2:${var.account_id}:submission_email_ses_successful_deliveries",
Expand Down
Loading