Skip to content

Assign cards to TODO: comments#2078

Open
DavidBiddle wants to merge 1 commit intomainfrom
assign-cards-to-todo-comments
Open

Assign cards to TODO: comments#2078
DavidBiddle wants to merge 1 commit intomainfrom
assign-cards-to-todo-comments

Conversation

@DavidBiddle
Copy link
Copy Markdown
Contributor

@DavidBiddle DavidBiddle commented Apr 8, 2026

What problem does this pull request solve?

Trello card: https://trello.com/c/hK0527GN/219-review-todo-comments-and-make-product-cards-for-any-that-are-still-relevant

As part of firebreak work we've reviewed the outstanding TODO: comments in this repo and made tech debt cards for them.

This PR adds references to those tech debt cards in the codebase, so that anyone tackling the TODO tasks in future can easily check the card for additional context.

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Has all relevant documentation been updated?

Reminders

If you've made changes to the deployer role (files in modules/deployer-access):

  • Remember to run make <environment> forms/account apply on the relevant environments (dev, staging, user-research, and/or prod)
  • Check the #govuk-forms-deployment-notifications Slack channel to ensure the apply-forms-terraform-<environment> pipelines have run successfully

@DavidBiddle DavidBiddle changed the title Reference Trello cards from TODO comments Assign cards to TODO: comments Apr 8, 2026
@DavidBiddle DavidBiddle marked this pull request as ready for review April 8, 2026 09:16
FullRepositoryId = "govuk-forms/forms-e2e-tests"
BranchName = "main"
# TODO: we should version this repository appropriately, so we can pick specific versions
# https://trello.com/c/CboxmYA2/3452-version-forms-e2e-tests-so-we-can-pick-specific-versions
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we actually want to do this... we don't version our apps, why would the end to end tests be different?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sarah added some context to the card, it sounds like it might have some benefits for predictability but it's not a big priority at the moment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants