Open
Conversation
TODO: comments
lfdebrux
reviewed
Apr 8, 2026
| FullRepositoryId = "govuk-forms/forms-e2e-tests" | ||
| BranchName = "main" | ||
| # TODO: we should version this repository appropriately, so we can pick specific versions | ||
| # https://trello.com/c/CboxmYA2/3452-version-forms-e2e-tests-so-we-can-pick-specific-versions |
Member
There was a problem hiding this comment.
I'm not sure we actually want to do this... we don't version our apps, why would the end to end tests be different?
Contributor
Author
There was a problem hiding this comment.
Sarah added some context to the card, it sounds like it might have some benefits for predictability but it's not a big priority at the moment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
Trello card: https://trello.com/c/hK0527GN/219-review-todo-comments-and-make-product-cards-for-any-that-are-still-relevant
As part of firebreak work we've reviewed the outstanding TODO: comments in this repo and made tech debt cards for them.
This PR adds references to those tech debt cards in the codebase, so that anyone tackling the TODO tasks in future can easily check the card for additional context.
Things to consider when reviewing
Reminders
If you've made changes to the deployer role (files in
modules/deployer-access):make <environment> forms/account applyon the relevant environments (dev,staging,user-research, and/orprod)apply-forms-terraform-<environment>pipelines have run successfully