Skip to content

Turn math cache into its own object #897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xmariachi wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Turn math cache into its own object #897

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
caff930
Turn math cache into its own object
xmariachi Dec 22, 2025
13c4ab6
fix linter, use cache also in CloseReputerNonce
xmariachi Dec 23, 2025
f37a276
add isInCache and adapt tests accordingly
xmariachi Dec 23, 2025
4191940
add changelog
xmariachi Dec 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Added

* [#851](https://github.com/allora-network/allora-chain/pull/851) Enforce recommended settings
* [#835](https://github.com/allora-network/allora-chain/pull/835): Introduce the `x/scheduler` module to manage tasks scheduling
* [#835](https://github.com/allora-network/allora-chain/pull/835) Introduce the `x/scheduler` module to manage tasks scheduling
* [#897](https://github.com/allora-network/allora-chain/pull/897) Turn math cache into its own object + use in closing reputer window

### Changed

Expand Down
12 changes: 12 additions & 0 deletions x/emissions/keeper/actor_utils/losses.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,17 @@ func CloseReputerNonce(
) (err error) {
blockHeight := ctx.BlockHeight()

// Create and enable math helper cache for this function's scope
cache := synth.NewMathHelperCache()
cache.Enable()

// Disable math helper cache and clear cache when function exits
defer func() {
cache.Disable()
cache.Clear()
ctx.Logger().Debug("Math helper cache cleared after CloseReputerNonce")
}()

// All filters should be done in order of increasing computational complexity
// Check if the worker nonce is unfulfilled
workerNonceUnfulfilled, err := k.IsWorkerNonceUnfulfilled(ctx, topic.Id, &nonce)
Expand Down Expand Up @@ -250,6 +261,7 @@ func CloseReputerNonce(
PNorm: topic.PNorm,
CNorm: params.CNorm,
StdDevPlusEpsilon: stdDevPlusEpsilon,
Cache: cache,
},
)
if err != nil {
Expand Down
Loading
Loading