Skip to content

Turn math cache into its own object #897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
xmariachi wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Turn math cache into its own object #897

xmariachi wants to merge 4 commits into from

Conversation

@xmariachi
Copy link
Contributor

@xmariachi xmariachi commented Dec 23, 2025 •
edited
Loading

Purpose of Changes and their Description

Turning math cache into an object instead of using global vars.

Are these changes tested and documented?

  • If tested, please describe how. If not, why tests are not needed. -- Added extensive unit tests, in both the cache and the usage.
  • If documented, please describe where. If not, describe why docs are not needed. -- It is a performance change, not a functionality change, so it should not need its own documentation.
  • Added to Unreleased section of CHANGELOG.md?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spooktheducks spooktheducks Awaiting requested review from spooktheducks spooktheducks is a code owner

@guilherme-brandao guilherme-brandao Awaiting requested review from guilherme-brandao guilherme-brandao is a code owner

@amimart amimart Awaiting requested review from amimart amimart is a code owner

@zale144 zale144 Awaiting requested review from zale144 zale144 is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xmariachi