Skip to content

Fixed professors showing undefined favorite lab #1439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shmowen merged 2 commits into from
Apr 1, 2026
Merged

Fixed professors showing undefined favorite lab #1439

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
998203c
Fixed professors showing undefined favorite lab
JackyFTW Mar 31, 2026
3526ab9
Also fixed interior scrollbar on lab13 based on new viewport changes
JackyFTW Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion client/src/components/exercise/lab13/Main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import IDEIntroduction from "./pages/IDEIntroduction";
*/
const Main = () => {
return (
<div className="bottomSpace tw-overflow-y-scroll tw-p-6">
<div className="bottomSpace tw-p-6">
<ExerciseStateProvider>
<Router className="app">
<ExerciseIntroduction default path="/" />
Expand Down
2 changes: 1 addition & 1 deletion client/src/pages/about-us/MemberDisplay.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ const MemberDisplay = (props) => {
})}
</div>
</div>
{currentMember.favoritelab !== null ? (
{currentMember.favoritelab ? (
<div id="member-favorite-lab">
<h4 className="tw-m-0 tw-mb-3 tw-font-bold tw-sub-title">
Favorite Lab
Expand Down
Loading