Fixed professors showing undefined favorite lab#1439
Merged
Conversation
Member
JackyFTW
commented
Mar 31, 2026
JackyFTW
commented
- No discrepancies across browsers (ex: chrome vs safari)
- Accessibility functions
- Pages can scale without distorting page
- No dead links
- Navbar is consistent across the site
- Pages are screen-reader accessible
- Contrast meets standards for accessibility
- Pages are keyboard accessible
- Code is cleaned up and bug-free (ex: debug statements removed)
shmowen
requested changes
Apr 1, 2026
Contributor
shmowen
left a comment
shmowen
left a comment
There was a problem hiding this comment.
The schema for the professors doesn't actually have a "favorite lab" column. I think this information would just be fine to remove??
INSERT INTO public.professors (id, "firstName", "lastName", title, affiliation, "imageURL", socials, aboutme, work, "datesActive")
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.