Skip to content

fix: embark-export-dired fails when used in combination with e.g consult-fd #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rampunda wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: embark-export-dired fails when used in combination with e.g consult-fd #365

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion dirvish.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1480,7 +1480,17 @@ With optional NOSELECT just find files but do not select them."
(flags (or flags (dv-ls-switches dv)))
(mc dirvish-large-directory-threshold)
(buffer (alist-get key (dv-roots dv) nil nil #'equal))
(new? (null buffer)) (dps (dv-preview-dispatchers dv))
;; embark-export-dired uses a hack to force dired to create a new
;; buffer documented here:
;; https://github.com/oantolin/embark/issues/675
;; make dirvish aware of it so it also creates new buffer. Without this
;; code when opening a directory in dirvish and then using e.g
;; consult-fd combined with embark-export in that folder it fails
;; because it tries to reuse the existing buffer
(new? (or
(null buffer)
(eq (symbol-function 'dired-find-buffer-nocreate) #'ignore)))
(dps (dv-preview-dispatchers dv))
(hist (cons key nil)) tramp fd)
(setf (dv-timestamp dv) (dirvish--timestamp))
(cond ((and new? remote)
Expand Down