fix: embark-export-dired fails when used in combination with e.g consult-fd#365
Open
rampunda wants to merge 1 commit intoalexluigit:mainfrom
Open
fix: embark-export-dired fails when used in combination with e.g consult-fd#365rampunda wants to merge 1 commit intoalexluigit:mainfrom
rampunda wants to merge 1 commit intoalexluigit:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi
Sorry for writing a crap description. Just don't want to spend a lot of time on this if it never goes anywhere.
Let me know if you see this and want it merged and I'll fix it up with proper steps to reproduce etc
Summary of the problem and fix:
;; embark-export-dired uses a hack to force dired to create a new
;; buffer documented here:
;; oantolin/embark#675
;; make dirvish aware of it so it also creates new buffer. Without this
;; code when opening a directory in dirvish and then using e.g
;; consult-fd combined with embark-export in that folder it fails
;; because it tries to reuse the existing buffer