(fix) remove buggy checks from IsSnowflake + (feature) add JSON conversion

src/FlakeId.Tests/ParseTests.cs

@@ -2,6 +2,7 @@
 using System.Collections.Generic;
 using System.Diagnostics;
 using System.Linq;
+using System.Text.Json;
 using Microsoft.VisualStudio.TestTools.UnitTesting;
 
 namespace FlakeId.Tests
@@ -73,5 +74,34 @@ public void Id_TryParse_Problematic()
         {
             Id id = Id.Parse(1108047973760811023);
         }
+
+        public class IdJson
+        {
+            public required Id Id { get; set; }
+        }
+
+        [TestMethod]
+        public void Id_JsonConverter_Read()
+        {
+            const string json = "{\"Id\":1108047973760811023}";
+
+            var obj = JsonSerializer.Deserialize<IdJson>(json);
+
+            Assert.IsNotNull(obj);
+            Assert.AreEqual(1108047973760811023, obj.Id);
+        }
+
+        [TestMethod]
+        public void Id_JsonConverter_Write()
+        {
+            var obj = new IdJson
+            {
+                Id = Id.Parse(1108047973760811023)
+            };
+
+            string json = JsonSerializer.Serialize(obj);
+
+            Assert.AreEqual("{\"Id\":\"1108047973760811023\"}", json);
+        }
     }
 }

src/FlakeId/Extensions/FlakeIdJsonConverter.cs

@@ -0,0 +1,35 @@
+using System;
+using System.Text.Json;
+using System.Text.Json.Serialization;
+
+namespace FlakeId.Extensions
+{
+    public class FlakeIdJsonConverter : JsonConverter<Id>
+    {
+        public override Id Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options)
+        {
+            if (reader.TokenType == JsonTokenType.Number && reader.TryGetInt64(out long value))
+            {
+                return new Id(value);
+            }
+
+            if (reader.TokenType != JsonTokenType.String)
+            {
+                throw new JsonException("Invalid JSON token for FlakeId.Id");
+            }
+
+            string stringValue = reader.GetString();
+            if (stringValue != null && long.TryParse(stringValue, out long parsedValue))
+            {
+                return new Id(parsedValue);
+            }
+
+            throw new JsonException("Invalid JSON token for FlakeId.Id");
+        }
+
+        public override void Write(Utf8JsonWriter writer, Id value, JsonSerializerOptions options)
+        {
+            writer.WriteStringValue(value.ToString());
+        }
+    }
+}

src/FlakeId/Extensions/IdExtensions.cs

@@ -38,11 +38,9 @@ public static bool IsSnowflake(this Id id)
             // The closest we can get is by decomposing its components, and ensuring all of them are set
             // to values that would be valid for a snowflake.
             long timestamp = id >> TimestampOffset;
-            long thread = (id >> ThreadOffset) & Id.ThreadIdMask;
-            long process = (id >> ProcessOffset) & Id.ProcessIdMask;
             long increment = id & Id.IncrementMask;
 
-            return timestamp > 0 && thread > 0 && process > 0 && increment >= 0;
+            return timestamp > 0 && increment >= 0;
         }
 
         /// <summary>

src/FlakeId/FlakeId.csproj

@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFrameworks>netstandard2.0;net9.0</TargetFrameworks>
+    <TargetFrameworks>netstandard2.0;net8.0</TargetFrameworks>
     <GeneratePackageOnBuild>true</GeneratePackageOnBuild>
     <Description>Discord inspired, Twitter like implementation of Snowflake IDs, focused on performance. Snowflakes are 64 bit, highly optimized, decentralized, K-ordered, unique identifiers.</Description>
     <RepositoryUrl>https://github.com/aevitas/flakeid</RepositoryUrl>
@@ -36,4 +36,7 @@
     </None>
   </ItemGroup>
 
+  <ItemGroup Condition="'$(TargetFramework)' == 'netstandard2.0'">
+    <PackageReference Include="System.Text.Json" Version="8.0.5" />
+  </ItemGroup>
 </Project>

src/FlakeId/Id.cs

@@ -2,13 +2,15 @@
 using System.Diagnostics;
 using System.Threading;
 using FlakeId.Extensions;
+using System.Text.Json.Serialization;
 
 namespace FlakeId
 {
     /// <summary>
     ///     Represents a unique, K-ordered, sortable identifier.
     /// </summary>
     [DebuggerDisplay("{_value}")]
+    [JsonConverter(typeof(FlakeIdJsonConverter))]
     public struct Id : IComparable<Id>, IEquatable<Id>
     {
         // This implementation of Snowflake ID is based on the specification as published by Discord: