(fix) remove buggy checks from IsSnowflake + (feature) add JSON conversion#28
(fix) remove buggy checks from IsSnowflake + (feature) add JSON conversion#28aevitas merged 2 commits intoaevitas:masterfrom
Conversation
(feature) add JSON conversion
|
Thanks the pull request, and happy new year! This is effectively #27 and then some - the holidays have stalled that PR for longer than I'd intended. There are some things we should be careful about in this PR though:
Let's start with the third. In the serializer, the This means that it will end up as a In order to properly serialize the struct, we'd need to write the value as a The first and second point are less complex fortunately. .NET 8 (the oldest still supported LTS) inherently supports And have the package target: I think combined with the fix to Thanks again! |
change Json Parser to parse to strings instead of numbers
|
Implemented the above changes with all tests passing! 👍 |
|
Heya! Just bumping this for visibility. Would this be good to merge? Thanks! |
|
I've just released v1.3.1 which includes this change, thanks for the contribution! |
This is a combination of #27 as well as a new feature for JSON Serialization/Deserialization. Unit tests have been added and all are passing. This also adds package System.Text.Json.