Skip to content

[MWPW-184575] - Tooltip mobile fix #5192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DKos95 wants to merge 10 commits into
base: stage
Choose a base branch
from
Open

[MWPW-184575] - Tooltip mobile fix #5192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9b63f38
[MWPW-184575] - tooltip fix
DKos95 Dec 1, 2025
ee5582d
[MWPW-184575] - tooltip fix
DKos95 Dec 1, 2025
683780d
[MWPW-184575] - tooltip fix
DKos95 Dec 1, 2025
66fa3ab
[MWPW-184575] - tooltip fix
DKos95 Dec 1, 2025
8ee259a
[MWPW-184575] - tooltip fix
DKos95 Dec 3, 2025
7749f2e
[MWPW-184575] - tooltip close on icon click
DKos95 Dec 3, 2025
d8bc102
[MWPW-184575] - tooltip touch and click use case
DKos95 Dec 4, 2025
bf317ef
[MWPW-184575] - tooltip remove close on click
DKos95 Dec 4, 2025
d99b615
[MWPW-184575] - tooltip remove blur
DKos95 Dec 11, 2025
42a3cee
[MWPW-184575] - tooltip remove blur
DKos95 Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libs/features/icons/icons.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ function decorateToolTip(icon, iconName) {
wrapper.parentElement.replaceChild(icon, wrapper);

import('../../scripts/tooltip.js').then(({ default: addTooltipListeners }) => {
addTooltipListeners(icon);
addTooltipListeners();
});
}

Expand Down
14 changes: 4 additions & 10 deletions libs/scripts/tooltip.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,25 +70,19 @@ function setTooltipPosition(tooltips) {
});
}

export default function addTooltipListeners(ownerElement) {
ownerElement?.addEventListener('click', () => {
ownerElement.classList.add('hide-tooltip');
});
export default function addTooltipListeners() {
['keydown', 'mouseenter', 'focus', 'mouseleave', 'blur'].forEach((eventType) => {
document.addEventListener(eventType, (event) => {
if (ownerElement && !ownerElement.classList.contains('hide-tooltip')
&& eventType === 'keydown' && event.key === 'Escape') {
ownerElement.classList.add('hide-tooltip');
}

const isTooltip = event.target?.matches?.('.milo-tooltip');
if (!isTooltip) return;
if (!isTooltip && eventType !== 'keydown') return;

if (['mouseenter', 'focus'].includes(eventType)) {
event.target.classList.remove('hide-tooltip');
setTooltipPosition([event.target]);
} else if (['mouseleave', 'blur'].includes(eventType)) {
event.target.classList.add('hide-tooltip');
} else if (eventType === 'keydown' && event.key === 'Escape') {
document.querySelector('.milo-tooltip:not(.hide-tooltip)')?.classList.add('hide-tooltip');
}
}, true);
});
Expand Down
Loading