-
Notifications
You must be signed in to change notification settings - Fork 212
[MWPW-184575] - Tooltip mobile fix #5192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: stage
Are you sure you want to change the base?
Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
|
5dd2125 to
1baeec8
Compare
|
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
d1896c1 to
42a3cee
Compare
|
Reminder to set the |
biljana-cvijanovic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Validated. Testing details https://jira.corp.adobe.com/browse/MWPW-184575
This PR enables tooltips to be used on mobile while preserving the ability to close them on Escape o̶r̶ o̶n̶ t̶o̶o̶l̶t̶i̶p̶ C̶l̶i̶c̶k̶.
Update:
After consulting with Taryn it has been confirmed that Escape or clicking/touching outside of the tooltip is enough to close the tooltip since there is no close button there is no need to implement a close on Click which has been giving us some problems, so it is probably best if we remove it since it is not necessary.
Resolves: MWPW-184575
CC Test URLs:
Test URLs: