MWPW-183392: Strikethrough price fix in express cards #5125
Conversation
…ency - Renamed CSS class from `.price-recurrence` to `.price-unit-type` for better semantic meaning. - Updated strikethrough price styling to include additional selectors for improved visual representation. - Ensured consistent application of styles across both simplified and full pricing express variants. - Adjusted media queries for better responsiveness on mobile devices.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
mirafedas
left a comment
mirafedas
left a comment
There was a problem hiding this comment.
Approved (the test blank shows as blank for me, not sure if it's me missing some permissions or smth with the test page)
|
Reminder to set the |
|
@Axelcureno you need full milolibs in the test url
vs prod/figma
|
…ariants - Added font styling for `.price-recurrence` in both simplified and full pricing express variants. - Updated selectors to include `.price-unit-type` for improved clarity in pricing representation. - Ensured consistent application of styles across all relevant files.
|
both items have been addressed @afmicka. Thank you 🙏🏼 |
|
@Axelcureno sorry i did not point that out, but the regular price on simplified card color got this blue color with your changes (visible on previous screenshots too). Full pricing already has that blue color on prod too but i don't see it in figma on any of the cards. Was there any requirement for it? your branch: prod: |
|
This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label. |
…following strikethrough
|
All comments resolved. Ready for QA. |
|
@Axelcureno this looks fixed but due to the code switch we are not merging PRs to milo and the mas part needs to go to the MAS repo and be merged first there. Lets sync about this today with the team |
|
PR moved to adobecom/mas#478 |
5 participants
Fixes strikethrough issues in prices.
Resolves: MWPW-183392
test url: https://mas.adobe.com/studio.html?milolibs=mwpw-183392--milo--adobecom#page=content&path=express&tags=mas%3Avariant%2Fsimplified-pricing-express%2Cmas%3Avariant%2Ffull-pricing-expressTest URLs: