Skip to content

Conversation

@Axelcureno
Copy link
Member

@Axelcureno Axelcureno commented Dec 15, 2025

Fixes strikethrough issues in prices.

Resolves: MWPW-183392

Related Milo PR: adobecom/milo#5125

Test URL: https://main--mas--adobecom.aem.live/web-components/docs/express.html

Fixes strikethrough issues in prices for simplified-pricing-express and full-pricing-express cards.
@aem-code-sync
Copy link

aem-code-sync bot commented Dec 15, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-sync branch
Commits

@Axelcureno Axelcureno self-assigned this Dec 15, 2025
@honstar
Copy link
Contributor

honstar commented Dec 16, 2025

@Axelcureno, do you have a link on your branch where this can be tested? Is there an express card where the fixed styles can be verified somewhere in here: https://mwpw-183392--mas--adobecom.aem.live/studio.html#page=content&path=express

@afmicka
Copy link
Collaborator

afmicka commented Dec 16, 2025

@Axelcureno, do you have a link on your branch where this can be tested? Is there an express card where the fixed styles can be verified somewhere in here: https://mwpw-183392--mas--adobecom.aem.live/studio.html#page=content&path=express

@honstar the 4th fragment (link) in Express surface is a good candidate for checking the changes. Compare how any pricing fragment looks on https://main--mas--adobecom.aem.live/studio.html#page=content&path=express

or this one is even better example - https://mwpw-183392--mas--adobecom.aem.live/studio.html#page=content&path=express&query=59f7d2ba-82f4-4d71-baeb-c55bfd029ec6

You will see
Screenshot 2025-12-16 at 10 17 59

vs
Screenshot 2025-12-16 at 10 18 05

@Axelcureno please keep testing urls in the PR description (before and after). Do not remove them.
Also, could you please add an example to our testing mas gallery page - https://main--mas--adobecom.aem.live/web-components/docs/express.html. Update one of the fragments and adjust Nala if needed, please.

Copy link
Contributor

@honstar honstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@afmicka
Copy link
Collaborator

afmicka commented Dec 24, 2025

@Axelcureno strikethrough price color on full pricing Express fragment is not per figma, it is much darker.
It is fixed on simplified pricing. Though i am not confused what the colors should be because i see 2 different examples in figma

full pricing with your branch
Screenshot 2025-12-24 at 16 35 36

simplified with your branch:
Screenshot 2025-12-24 at 16 35 42

figma with both
Screenshot 2025-12-24 at 16 38 19

confusing figma (we still have this combination on prod but is changed with this branch, not sure which one is correct):

Screenshot 2025-12-24 at 16 41 25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do not merge PR should not be merged yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants