-
Notifications
You must be signed in to change notification settings - Fork 15
MWPW-183392: Strikethrough price fix in express cards #478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Fixes strikethrough issues in prices for simplified-pricing-express and full-pricing-express cards.
|
@Axelcureno, do you have a link on your branch where this can be tested? Is there an express card where the fixed styles can be verified somewhere in here: https://mwpw-183392--mas--adobecom.aem.live/studio.html#page=content&path=express |
@honstar the 4th fragment (link) in Express surface is a good candidate for checking the changes. Compare how any pricing fragment looks on https://main--mas--adobecom.aem.live/studio.html#page=content&path=express or this one is even better example - https://mwpw-183392--mas--adobecom.aem.live/studio.html#page=content&path=express&query=59f7d2ba-82f4-4d71-baeb-c55bfd029ec6 @Axelcureno please keep testing urls in the PR description (before and after). Do not remove them. |
honstar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@Axelcureno strikethrough price color on full pricing Express fragment is not per figma, it is much darker. confusing figma (we still have this combination on prod but is changed with this branch, not sure which one is correct):
|






Fixes strikethrough issues in prices.
Resolves: MWPW-183392
Related Milo PR: adobecom/milo#5125
Test URL: https://main--mas--adobecom.aem.live/web-components/docs/express.html