Skip to content

Conversation

@mirafedas
Copy link
Contributor

@mirafedas mirafedas commented Dec 22, 2025

Resolves https://jira.corp.adobe.com/browse/MWPW-182079

Nala test should be updated in Milo: PR

  1. Fixed finding price literals for ID_id (it should use "in" literals);
  2. Added tax setting forZA_en;
  3. Updated the following price literals:
Lang Field New Value Previous Value
ar taxExclusiveLabel VAT باستثناء ضريبة excl. VAT
ar taxInclusiveLabel VAT شاملاً الضريبة incl. VAT
bg taxExclusiveLabel VAT без ДДС excl. VAT
bg taxInclusiveLabel VAT с включен ДДС incl. VAT
et taxExclusiveLabel VAT käibemaksuta excl. VAT
et taxInclusiveLabel VAT käibemaksuga incl. VAT
fr taxExclusiveLabel VAT HT hors TVA
fr taxInclusiveLabel VAT TTC TVA comprise
hu taxExclusiveLabel VAT áfa nélkül excl. VAT
hu taxInclusiveLabel VAT áfával incl. VAT
ko taxExclusiveLabel VAT 부가세 별도 VAT 제외
ko taxInclusiveLabel VAT 부가세 포함 VAT 포함
lt taxExclusiveLabel VAT be PVM excl. VAT
lt taxInclusiveLabel VAT su PVM incl. VAT
lv taxExclusiveLabel VAT bez PVN excl. VAT
lv taxInclusiveLabel VAT ar PVN incl. VAT
pl taxInclusiveLabel VAT w tym VAT z VAT
ro taxExclusiveLabel VAT fără TVA excl. VAT
ro taxInclusiveLabel VAT cu TVA incl. VAT
sk taxExclusiveLabel VAT bez DPH excl. VAT
sk taxInclusiveLabel VAT vrátane DPH incl. VAT
sl taxExclusiveLabel VAT brez DDV-ja excl. VAT
sl taxInclusiveLabel VAT z DDV-jem incl. VAT
uk taxExclusiveLabel VAT без урахування ПДВ без ПДВ
uk taxInclusiveLabel VAT з ПДВ разом із ПДВ
es taxExclusiveLabel VAT sin IVA IVA no incluido
in taxExclusiveLabel VAT sebelum PPN tidak termasuk PPN
el taxExclusiveLabel VAT (εξαιρ. ΦΠΑ) (μη συμπεριλαμβανομένου ΦΠΑ)
el taxInclusiveLabel VAT (συμπερ. ΦΠΑ) (συμπεριλαμβανομένου ΦΠΑ)
ms taxExclusiveLabel SST SST dikecualikan kecuali SST
  1. This PR includes changes related ot tax labels from the following PRs to avoid conflicts/regressions:
    https://github.com/adobecom/mas/pull/493/files
    https://github.com/adobecom/mas/pull/498/files

Resolves: MWPW-182079

Find the list of all test pages in column G here.

In this file is the current state of tax and unit labels with the mas-ff-defaults flag set to 'ON'.

QA Checklist: https://wiki.corp.adobe.com/display/adobedotcom/M@S+Engineering+QA+Use+Cases

Please do the steps below before submitting your PR for a code review or QA

  • C1. Cover code with Unit Tests
  • C2. Add a Nala test (double check with #fishbags if nala test is needed) - Nala test should be updated in Milo, PR
  • C3. Verify all Checks are green (unit tests, nala tests)
  • C4. PR description contains working Test Page link where the feature can be tested
  • C5: you are ready to do a demo from Test Page in PR (bonus: write a working demo script that you'll use on Thursday, you can eventually put in your PR)
  • C.6 read your Jira one more time to validate that you've addressed all AC's and nothing is missing

🧪 Nala E2E Tests

Nala tests run automatically when you open this PR.

To run Nala tests again:

  1. Add the run nala label to this PR (in the right sidebar)
  2. Tests will run automatically on the current commit
  3. Any future commits will also trigger tests as long as the label remains

To stop automatic Nala tests:

  • Remove the run nala label

Note: Tests only run on commits if the run nala label is present. Add the label whenever you need tests to run on new changes.

Test URLs:

Test URLs:

@aem-code-sync
Copy link

aem-code-sync bot commented Dec 22, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-sync branch
Commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do not merge PR should not be merged yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants