MWPW-185252 [M@S] Tax label and Include tax toggle broken

[bozojovicic]

Resolves https://jira.corp.adobe.com/browse/MWPW-185252
QA Checklist: https://wiki.corp.adobe.com/display/adobedotcom/M@S+Engineering+QA+Use+Cases

Tacocat PR https://git.corp.adobe.com/wcms/tacocat.js/pull/676

MAS Studio test link https://mwpw-185252--mas--adobecom.aem.live/studio.html#locale=fr_FR&page=fragment-editor&path=sandbox
Milo OST test link https://mwpw185252tax--milo--bozojovicic.aem.live/tools/ost?maslibs=MWPW-185252

Please do the steps below before submitting your PR for a code review or QA

• C1. Cover code with Unit Tests
• C2. Add a Nala test (double check with #fishbags if nala test is needed)
• C3. Verify all Checks are green (unit tests, nala tests)
• C4. PR description contains working Test Page link where the feature can be tested
• C5: you are ready to do a demo from Test Page in PR (bonus: write a working demo script that you'll use on Thursday, you can eventually put in your PR)
• C.6 read your Jira one more time to validate that you've addressed all AC's and nothing is missing

🧪 Nala E2E Tests

Nala tests run automatically when you open this PR.

To run Nala tests again:

1. Add the run nala label to this PR (in the right sidebar)
2. Tests will run automatically on the current commit
3. Any future commits will also trigger tests as long as the label remains

To stop automatic Nala tests:

• Remove the run nala label

Note: Tests only run on commits if the run nala label is present. Add the label whenever you need tests to run on new changes.

Test URLs:

• Before: https://main--mas--adobecom.aem.live/
• After: https://mwpw-185252--mas--adobecom.aem.live/

[aem-code-sync]

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
In case there are problems, just click the checkbox below to rerun the respective action.

• Re-sync branch

Commits

• 133f948 ✅ (latest)
• f593db2 ✅
• dc26918 ✅
• fadfd0a ✅
• 5857960 ✅
• 23e7724 ✅

[mirafedas]

Cannot find this change listed in the description of the Jira: https://jira.corp.adobe.com/browse/MWPW-185252 , could you please link the Jira where it was requested?
I included this change in my PR: #499 to not cause conflicts/regressions, and updated the documentation I added accordingly.

---

And in the PR description you need to update the first line:
Resolves https://jira.corp.adobe.com/browse/MWPW-NUMBER > Resolves https://jira.corp.adobe.com/browse/MWPW-185252

[bozojovicic]

Right. Good catch. This is not requested anywhere. This is something that I noticed in production and I think it is a mistake in that excel file with tax included/excluded per country. For students it is included for sa_en but excluded for sa_ar (and tax label not displayed), which is not logical at all. So I changed that table in the code to have it as we have now in production.
But I will double check this with Lucy and Ravneet. Thanks for reminding me. Will CC you.

[bozojovicic]

https://jira.corp.adobe.com/browse/MWPW-185252?focusedId=51912866&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-51912866