MWPW-185252 [M@S] Tax label and Include tax toggle broken #5274
+132
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
December 22, 2025 12:02
mirafedas
requested changes
Dec 23, 2025
mirafedas
approved these changes
Dec 26, 2025
| input.addEventListener('change', onChange); | ||
| } | ||
|
|
||
| function addToggleSwitches(el, ostEnv) { |
Contributor
There was a problem hiding this comment.
In https://github.com/adobecom/milo/pull/5193/files this function accepts more params, let's unify to avoid conflicts
Contributor
|
This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properly handle OST flags
taxandexclusivein OST with MAS defaults enabled.Styles for toggle buttons on the right are not part of this PR. Hopefully that will be merged in this PR #5193 before this one is merged.
MAS PR adobecom/mas#498
Test link for Milo OST https://mwpw185252tax--milo--bozojovicic.aem.live/tools/ost?maslibs=MWPW-185252
Resolves: MWPW-185252
Test URLs: