Skip to content

Conversation

@saurabhsircar11
Copy link
Collaborator

@saurabhsircar11 saurabhsircar11 commented Dec 10, 2025

  • Added changes for translated aria labels for play and pause motion.
  • Using placeholders json for translated aria-label text

Resolves: https://jira.corp.adobe.com/browse/MWPW-185102

Test URLs:

@aem-code-sync
Copy link

aem-code-sync bot commented Dec 10, 2025

Page Scores Audits Google
📱 /drafts/ssircar/filltemp?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /drafts/ssircar/filltemp?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.88%. Comparing base (3d398b2) to head (28d5430).
⚠️ Report is 6 commits behind head on stage.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage     #842      +/-   ##
==========================================
- Coverage   88.74%   87.88%   -0.87%     
==========================================
  Files          41       42       +1     
  Lines        9019     9079      +60     
==========================================
- Hits         8004     7979      -25     
- Misses       1015     1100      +85     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@milo-pr-merge-cc
Copy link

Skipped merging 842: Mwpw 185102: play pause loc aria due to failing checks

@milo-pr-merge-cc
Copy link

Skipped merging 842: Mwpw 185102: play pause loc aria due to missing verified label. kindly make sure that the PR has been verified

@spadmasa spadmasa self-assigned this Dec 11, 2025
@spadmasa
Copy link
Collaborator

@nkthakur48 nkthakur48 merged commit b4007fc into adobecom:stage Dec 11, 2025
11 checks passed
@spadmasa spadmasa added the ready for main PR is ready to be merged to main branch label Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for main PR is ready to be merged to main branch ready for stage verified

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants