Skip to content

Conversation

nkthakur48 and others added 3 commits December 9, 2025 18:46
…ted-slot-text, animated-text-reveal, and bento-grid (#839)

* feat: added initial changes for text reveal block

* feat:animated-text-reveal: changed to character by character instead of word

* feat:animated-text-reveal: changed animation calc

* feat:animated-text-reveal: removed xl spacing

* feat:animated-text-reveal: Added lana logs and fixed linting

* feat:animated-text-reveal: removed width and added contain increase performance

* feat: animated-text-reveal: changed to twin layer for accessibility, added lastcount to reduce to reduce looping iterations

* feat: animated-text-reveal: highlight changes

* fix: animated-text-reveal: split issue fix for word

* Fixed linter issues for animated-text-reveal.js

* feat:animated-slot-text: added animations and css

* feat:animated-slot-text: changed threshold to 1.0

* feat:animated-slot-text: changed to linear

* feat:animated-slot-text: removed hardcoded background and getting from section metadata

* feat: animated-slot-text: centered the slot and prefix, refined authoring with additional inputs

* feat: Working animated-photo-banner

* feat: animated-slot-text: removed padding

* feat:animated-slot-text: fixed mobile issue

* feat(animated-photo-banner): add support for non-animated images

* feat:animated-slot-text: fixed font and added media queries

* feat:animated-slot-text: added window and removed various line height

* feat:animated-slot-text: add a11y changes

* feat: [animated-photo-banner] Animation will start after all images are loaded

* feat: refactored getScreenSizeCategory as utility method

* feat: animating text section

* Corrected font in animated-photo-banner

* feat: animated-photo-banner: Added support for optional height for container

* fix: animated-photo-banner: description width updated

* fix: animated-slot-text: Corrected margin for slot window

* fix: animated-photo-banner: Wave 0 handling

* feat: animated-photo-banner: Support for limited image sizes

* Removing redundant file

* feat: animated-photo-banner: Support custom breakpoints for NorthStar

* feat: animated-photo-banner wave=-1 are not rendered

* refactor: animated-photo-banner: Massive refactoring follwing Clean Code

* refactor: animated-photo-banner: Removed viewportChangeHandlers for now

* fix: animated-photo-banner: Banner Header shouldn't be animated on Tablet

* feat: animated-photo-banner: Added styles for tablet

* feat: animated-photo-banner: Added Mobile styles

* feat: animated-slot-machine: Fade effect init

* feat: animated-photo-banner: Corrected Mobile styles

* fix: animated-photo-banner: tweaked animation configs

* feat: animated-slot-text: added create tag

* feat: animated-slot-text: added transition start to remove mask

* feat: animated-slot-text: fixed issues

* feat: animated-slot-text: added animation in mask image

* feat: animated-slot-text: improved smoothening

* feat: animated-slot-text: fixed the es lint issues

* fix: animated-photo-banner: Removed font-family override

* feat: animated-slot-text: added debounce for resize

* feat: animated-slot-text: reduced black gradient

* refactor: animated-slot-text: massive refactoring into sections

* fix: animated-slot-text: Lana label and eslint issues

* MWPW-184663: Remove transition animation after sequence is complete

* feat: photo-gallery: added changes for photo gallery

* feat: photo-gallery: added 1200px breakpoint

* MWPW-184764: Font-size and body copy width updates

* feat: photo-gallery: removed 1200px breakpoint

* fix: animated-photo-banner: Added border-radius in images

* feat: photo-gallery: added min items 30

* feat: photo-gallery: added performance for 30 items

* feat: photo-gallery: start index rotation

* feat: photo-gallery: lazy for duplicates

* feat: photo-gallery: decreased gap

* feat: photo-gallery: changed margin metric to px

* feat: photo-gallery: reduced border radius

* feat: photo-gallery: increased desktop width and height of photo gallery

* feat: photo-gallery: increased vertical gap

* feat: photo-gallery: removed variable

* feat: photo-gallery: increased min width for desktop

* feat: bento-grid: changed to bento-grid from photo gallery

* feat: bento-grid: added dummy content

* feat: bento-grid: added dummy content

* feat: bento-grid: removed dummy comment

* feat: bento-grid: changed css name

* feat: perf: optimise size and drop wave=-1 images from DOM

* fix: Removed refactoring notes

* feat:bento grid: min items target to 15

* fix: animated-photo-banner: Corrected font-size and line-height for body copy

* refactor: animated-photo-banner: Cleaned check for hidden wave

* fix: firefly-gallery: Fixed UTs due to incorrect import

* feat: animated-photo-banner: A11Y support for prefers-reduced-motion

* feat: animated-slot-text: added accessibility control

* feat: animated-slot-text: updated to forty px

* feat: animated-slot-text: handled reference of tranistionend and added a timer for icon on last item

* feat: animated-slot-text: removed timer for play icon

* fix: animated-photo-banner: Case-insensitive params

* fix: bento-grid: Corrected gap between rows and cards

* feat: animated-photo-banner: Updated image sizes

---------

Co-authored-by: Saurabh Sircar <saurabhsircar11@gmail.com>
* MWPW-185053: add fallback for URLs for offer terms

* fix tests

* fix lint

* mock fetch

* fix test failures due to redirection

* fix unit tests

* Align node version with Milo

* update fallback urls

* fix tests

* fix lint

* clean up

* edge case handling
@milo-pr-merge-cc
Copy link
Author

Testing can start @adobecom/creative-cloud-sot

@aem-code-sync
Copy link

aem-code-sync bot commented Dec 10, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync
Copy link

aem-code-sync bot commented Dec 10, 2025

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@nkthakur48 nkthakur48 changed the title [Release] Stage to Main 12/10 [Release] Stage to Main 12/11 Dec 10, 2025
@Roycethan
Copy link
Collaborator

#844 - validated on stage fyi @spadmasa

* feat: animated-slot-text:MWPW-185102 added translated aria labels

* feat: common function to fetch placeholders

* feat: animated-slot-text: removed only fullstop

* feat: removed unused argument

---------

Co-authored-by: Nishant Thakur <nishant.thakur.ece@gmail.com>
@spadmasa
Copy link
Collaborator

Validation done in stage on below url
https://www.stage.adobe.com/made-to-create.html
image
image
image

image image image image image

@spadmasa spadmasa added verified ready for main PR is ready to be merged to main branch labels Dec 11, 2025
@sigadamvenkata
Copy link
Collaborator

CMR : CHG002882551

@spadmasa
Copy link
Collaborator

cmr CHG002882551

@sigadamvenkata sigadamvenkata merged commit 9243173 into main Dec 11, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for main PR is ready to be merged to main branch verified

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants