Skip to content

MWPW-185053: add fallback URLs for offer terms #841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
milo-pr-merge-cc merged 14 commits into from
Dec 10, 2025
Merged

MWPW-185053: add fallback URLs for offer terms #841

milo-pr-merge-cc merged 14 commits into from
Dec 10, 2025

Conversation

@yesil
Copy link
Contributor

@yesil yesil commented Dec 9, 2025 •
edited
Loading

Add fallback URLs for offer terms.

Resolves: MWPW-185053

Test URLs::

Before: https://main--cc--adobecom.aem.live/?martech=off
After: https://mwpw-185053--cc--adobecom.aem.live/?martech=off

add https:// to the urls.

Before:
main--cc--adobecom.aem.live/offers/promo-terms?locale=fr_BE&country=BE&offer_id=951DCCB08194F40B9C79951675547DF5&martech=off

after:
mwpw-185053--cc--yesil.aem.live/offers/promo-terms?locale=en_US&country=US&offer_id=951DCCB08194F40B9C79951675547DF5&martech=off

France

/mwpw-185053--cc--yesil.aem.live/offers/promo-terms?locale=fr_FR&country=FR&offer_id=951DCCB08194F40B9C79951675547DF5&martech=off

Mexico:
mwpw-185053--cc--yesil.aem.live/offers/promo-terms?locale=es_MX&country=MX&offer_id=951DCCB08194F40B9C79951675547DF5&martech=off

@aem-code-sync
Copy link

aem-code-sync bot commented Dec 9, 2025 •
edited
Loading

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@yesil yesil changed the title MWPW-185053: add fallback for URLs for offer terms MWPW-185053: add fallback URLs for offer terms Dec 9, 2025
@milo-pr-merge-cc
Copy link

milo-pr-merge-cc bot commented Dec 9, 2025

Skipped merging 841: MWPW-185053: add fallback URLs for offer terms due to failing checks

@milo-pr-merge-cc
Copy link

milo-pr-merge-cc bot commented Dec 10, 2025

Skipped merging 841: MWPW-185053: add fallback URLs for offer terms due to missing verified label. kindly make sure that the PR has been verified

Axelcureno
Axelcureno approved these changes Dec 10, 2025
View reviewed changes
Copy link
Member

@Axelcureno Axelcureno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Roycethan
Copy link
Collaborator

Roycethan commented Dec 10, 2025 •
edited
Loading

Use-case given in this PR checked and non-regressions performed on cc pages. lgtm.

fyi @spadmasa

@milo-pr-merge-cc milo-pr-merge-cc bot merged commit 5186899 into adobecom:stage Dec 10, 2025
11 of 12 checks passed
@milo-pr-merge-cc milo-pr-merge-cc bot mentioned this pull request Dec 10, 2025
Merged
@Roycethan Roycethan added the ready for main PR is ready to be merged to main branch label Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@npeltier npeltier npeltier approved these changes

@Axelcureno Axelcureno Axelcureno approved these changes

@Roycethan Roycethan Roycethan approved these changes

@nkthakur48 nkthakur48 Awaiting requested review from nkthakur48

@bozojovicic bozojovicic Awaiting requested review from bozojovicic

@seanchoi-dev seanchoi-dev Awaiting requested review from seanchoi-dev

Assignees

No one assigned

Labels

ready for main PR is ready to be merged to main branch ready for stage verified

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yesil @Roycethan @npeltier @Axelcureno